Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 1382673002: PPC: [es6] Introduce spec compliant IsConstructor. (Closed)

Created:
5 years, 2 months ago by MTBrandyberry
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [es6] Introduce spec compliant IsConstructor. Port 8fe3ac07014ce5891be0a1cbd8019e9f3b02ff0b Original commit message: There was already a bit on the Map named "function with prototype", which basically meant that the Map was a map for a JSFunction that could be used as a constructor. Now this CL generalizes that bit to IsConstructor, which says that whatever (Heap)Object you are looking at can be used as a constructor (i.e. the bit is also set for bound functions that can be used as constructors and proxies that have a [[Construct]] internal method). This way we have a single chokepoint for IsConstructor checking, which allows us to get rid of the various ways in which we tried to guess whether something could be used as a constructor or not. Drive-by-fix: Renamed IsConstructor on FunctionKind to IsClassConstructor to resolve the weird name clash, and the IsClassConstructor name also matches the spec. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4413, v8:4430 LOG=n Committed: https://crrev.com/623e8021322325cc979a7e32af81627db4bad98b Cr-Commit-Position: refs/heads/master@{#31027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -25 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +40 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years, 2 months ago (2015-09-30 16:33:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382673002/1
5 years, 2 months ago (2015-09-30 16:33:19 UTC) #3
dstence
lgtm
5 years, 2 months ago (2015-09-30 16:37:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 16:55:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382673002/1
5 years, 2 months ago (2015-09-30 16:59:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 17:01:08 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 17:01:26 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/623e8021322325cc979a7e32af81627db4bad98b
Cr-Commit-Position: refs/heads/master@{#31027}

Powered by Google App Engine
This is Rietveld 408576698