Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1382633002: PPC: [runtime] Remove weird pushing of something on StackOverflow. (Closed)

Created:
5 years, 2 months ago by MTBrandyberry
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [runtime] Remove weird pushing of something on StackOverflow. Port 556b522ac62414c87d05f5d6bab33f6b6cab9b13 Original commit message: We somehow try to push some stuff on the stack when we detect a stack overflow, that we don't need. Even worse we might access outside the valid stack bounds. Since we don't need this, it's gone. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=chromium:534881 LOG=n Committed: https://crrev.com/aa30d4e29d782d52dcb870e80e7cad71685758ba Cr-Commit-Position: refs/heads/master@{#31026}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M src/ppc/builtins-ppc.cc View 5 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years, 2 months ago (2015-09-30 15:31:38 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382633002/1
5 years, 2 months ago (2015-09-30 15:31:48 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 15:55:43 UTC) #5
michael_dawson
On 2015/09/30 15:55:43, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 2 months ago (2015-09-30 16:21:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382633002/1
5 years, 2 months ago (2015-09-30 16:26:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 16:30:13 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 16:30:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa30d4e29d782d52dcb870e80e7cad71685758ba
Cr-Commit-Position: refs/heads/master@{#31026}

Powered by Google App Engine
This is Rietveld 408576698