Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 138263003: Remove Chrome Frame hacks from net tests. (Closed)

Created:
6 years, 11 months ago by grt (UTC plus 2)
Modified:
6 years, 11 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org, tzik
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : clean up issue 317432 hack as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -26 lines) Patch
M net/url_request/url_request_unittest.cc View 1 5 chunks +3 lines, -26 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
grt (UTC plus 2)
6 years, 11 months ago (2014-01-14 15:39:41 UTC) #1
wtc
Patch set 1 LGTM. Thanks. https://codereview.chromium.org/138263003/diff/1/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): https://codereview.chromium.org/138263003/diff/1/net/url_request/url_request_unittest.cc#newcode1958 net/url_request/url_request_unittest.cc:1958: // This is to ...
6 years, 11 months ago (2014-01-15 00:09:22 UTC) #2
grt (UTC plus 2)
Thanks, PTAL. https://codereview.chromium.org/138263003/diff/1/net/url_request/url_request_unittest.cc File net/url_request/url_request_unittest.cc (right): https://codereview.chromium.org/138263003/diff/1/net/url_request/url_request_unittest.cc#newcode1958 net/url_request/url_request_unittest.cc:1958: // This is to work around mysterious ...
6 years, 11 months ago (2014-01-15 14:29:10 UTC) #3
wtc
Patch set 2 LGTM!
6 years, 11 months ago (2014-01-15 19:44:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/138263003/160001
6 years, 11 months ago (2014-01-15 21:30:33 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247005
6 years, 11 months ago (2014-01-16 06:28:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/138263003/160001
6 years, 11 months ago (2014-01-16 14:48:58 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 18:27:40 UTC) #8
Message was sent while issue was closed.
Change committed as 245262

Powered by Google App Engine
This is Rietveld 408576698