third_party/WebKit/Source/web/ChromeClientImpl.h - Issue 1382593004: Allow out-of-process iframes to update the mouse cursor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.h

Issue 1382593004: Allow out-of-process iframes to update the mouse cursor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comments addressed Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/site_per_process_browsertest.cc ('K') | « third_party/WebKit/Source/core/page/ChromeClient.h ('k') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('j') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ChromeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.h b/third_party/WebKit/Source/web/ChromeClientImpl.h

index 46054cddc570156245c6da4be7c19726163403be..bed75e35accb21c17222440d506e38b12cd38dd9 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.h

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.h

@@ -110,7 +110,7 @@ public:

PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) override;

void openFileChooser(LocalFrame*, PassRefPtr<FileChooser>) override;

void enumerateChosenDirectory(FileChooser*) override;

- void setCursor(const Cursor&) override;

+ void setCursor(const Cursor&, LocalFrame* localRoot) override;

Cursor lastSetCursorForTesting() const override;

void needTouchEvents(bool needTouchEvents) override;

void setTouchAction(TouchAction) override;

@@ -184,7 +184,7 @@ private:

void unregisterPopupOpeningObserver(PopupOpeningObserver*) override;

void notifyPopupOpeningObservers() const;

- void setCursor(const WebCursorInfo&);

+ void setCursor(const WebCursorInfo&, LocalFrame* localRoot);

WebViewImpl* m_webView; // Weak pointer.

WindowFeatures m_windowFeatures;