Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 1382593004: Allow out-of-process iframes to update the mouse cursor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits addressed Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 void* webView() const override 150 void* webView() const override
151 { 151 {
152 return m_popup->m_webView; 152 return m_popup->m_webView;
153 } 153 }
154 154
155 IntSize minimumWindowSize() const override 155 IntSize minimumWindowSize() const override
156 { 156 {
157 return IntSize(0, 0); 157 return IntSize(0, 0);
158 } 158 }
159 159
160 void setCursor(const Cursor& cursor) override 160 void setCursor(const Cursor& cursor, LocalFrame* localRoot) override
161 { 161 {
162 if (m_popup->m_webView->client()) 162 if (m_popup->m_webView->client())
163 m_popup->m_webView->client()->didChangeCursor(WebCursorInfo(cursor)) ; 163 m_popup->m_webView->client()->didChangeCursor(WebCursorInfo(cursor)) ;
164 } 164 }
165 165
166 void needTouchEvents(bool needsTouchEvents) override 166 void needTouchEvents(bool needsTouchEvents) override
167 { 167 {
168 m_popup->widgetClient()->hasTouchEventHandlers(needsTouchEvents); 168 m_popup->widgetClient()->hasTouchEventHandlers(needsTouchEvents);
169 } 169 }
170 170
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 // A WebPagePopupImpl instance usually has two references. 539 // A WebPagePopupImpl instance usually has two references.
540 // - One owned by the instance itself. It represents the visible widget. 540 // - One owned by the instance itself. It represents the visible widget.
541 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 541 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
542 // WebPagePopupImpl to close. 542 // WebPagePopupImpl to close.
543 // We need them because the closing operation is asynchronous and the widget 543 // We need them because the closing operation is asynchronous and the widget
544 // can be closed while the WebViewImpl is unaware of it. 544 // can be closed while the WebViewImpl is unaware of it.
545 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 545 return adoptRef(new WebPagePopupImpl(client)).leakRef();
546 } 546 }
547 547
548 } // namespace blink 548 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/InspectorOverlay.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698