Add toStdString methods to CString and WTF::String

third_party/WebKit/Source/wtf/text/CString.h

 /*
  * Copyright (C) 2003, 2006, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 46 matching lines @@
 // A container for a null-terminated char array supporting copy-on-write
 // assignment.  The contained char array may be null.
 class WTF_EXPORT CString {
 public:
     CString() { }
     CString(const char*);
     CString(const char*, size_t length);
     CString(CStringBuffer* buffer) : m_buffer(buffer) { }
     static CString newUninitialized(size_t length, char*& characterBuffer);
 
+    std::string toStdString() const
+    {
+        return std::string(data(), length());

[Mikhail, 2015/09/30 14:02:01]

length() includes NULL terminator, so should be 'length() - 1'

[Primiano Tucci (use gerrit), 2015/09/30 15:08:28]

Just tried: String("").length()  returns 0 not 1.

If I do that (-1) the unittest (see the new empty one) crashes on an empty
string, with this:

[ RUN      ] StringTest.ToStdString
terminate called after throwing an instance of 'std::length_error'
  what():  basic_string::_S_create
Received signal 6
#0 0x7f5ae2d16e7b base::debug::(anonymous namespace)::StackDumpSignalHandler()
#1 0x7f5ae2246340 <unknown>
#2 0x7f5ae1ea7cc9 gsignal
#3 0x7f5ae1eab0d8 abort
#4 0x7f5ae27ba535 __gnu_cxx::__verbose_terminate_handler()
#5 0x7f5ae27b86d6 <unknown>
#6 0x7f5ae27b8703 std::terminate()
#7 0x7f5ae27b8922 __cxa_throw
#8 0x7f5ae280a387 std::__throw_length_error()
#9 0x7f5ae2814222 std::string::_Rep::_S_create()
#10 0x7f5ae2815931 std::string::_S_construct<>()
#11 0x7f5ae28159ed std::string::string()
#12 0x7f5ae2de6ca2 WTF::String::toUTF8()
#13 0x000000606554 WTF::StringTest_ToStdString_Test::TestBody()
#14 0x000000642c77 testing::Test::Run()
#15 0x00000064376a testing::TestInfo::Run()
#16 0x000000643c03 testing::TestCase::Run()
#17 0x00000064ad29 testing::internal::UnitTestImpl::RunAllTests()
#18 0x00000064a9ce testing::UnitTest::Run()
#19 0x00000060abad base::TestSuite::Run()
#20 0x000000617ad3 base::(anonymous namespace)::LaunchUnitTestsInternal()
#21 0x0000006179aa base::LaunchUnitTests()
#22 0x00000060aaa4 base::RunUnitTestsUsingBaseTestSuite()
#23 0x7f5ae1e92ec5 __libc_start_main
#24 0x00000042b9d0 <unknown>
  r8: 000000000000000a  r9: 00007f5ae2c1a780 r10: 0000000000000008 r11:
0000000000000206
 r12: 000026a8e78613e0 r13: 000026a8e785de00 r14: 00007ffca880eb78 r15:
000026a8e785afc0
  di: 00000000000079b1  si: 00000000000079b1  bp: 000026a8e78aa498  bx:
00007f5ae2230868
  dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp:
00007ffca880e828
  ip: 00007f5ae1ea7cc9 efl: 0000000000000206 cgf: 0000000000000033 erf:
0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]

[Mikhail, 2015/09/30 15:58:39]

Right. CStringBuffer's length != its size, sorry for the hassle..

+    }
+
     const char* data() const
     {
         return m_buffer ? m_buffer->data() : 0;
     }
     char* mutableData();
     size_t length() const
     {
         return m_buffer ? m_buffer->length() : 0;
     }
 
@@ skipping 11 matching lines @@
 WTF_EXPORT bool operator==(const CString& a, const CString& b);
 inline bool operator!=(const CString& a, const CString& b) { return !(a == b); }
 WTF_EXPORT bool operator==(const CString& a, const char* b);
 inline bool operator!=(const CString& a, const char* b) { return !(a == b); }
 
 } // namespace WTF
 
 using WTF::CString;
 
 #endif // CString_h