Split the desktop portion of application_lifetime.cc into its own file.

Split the desktop portion of application_lifetime.cc into its own file.

BUG=159847

[Lei Zhang, 2015-09-30 08:30:54]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2015-09-30 08:32:03]

Patchset #1 (id:20001) has been deleted

[Lei Zhang, 2015-09-30 19:08:43]

Patchset #1 (id:40001) has been deleted

[Lei Zhang, 2015-09-30 19:11:15]

thestig@chromium.org changed reviewers:
+ sky@chromium.org

[Lei Zhang, 2015-09-30 19:11:15]

The split is a bit messy and so is the diff.

Maybe I could move more code from anonymous namesspaces into
chrome/browser/lifetime/application_lifetime_internal.cc ? WDYT?

[sky, 2015-09-30 21:28:06]

Whenever I look at this code I get confused. It seems like we have far too many
functions here that aren't grouped in meaningful way. For example, why do we
need the Notify functions to be public? Similarly why is StartShutdownTracing
here? Can it be called at the right time by this code?

Can you take this opportunity to cleanup this code and call sites?

[Lei Zhang, 2015-09-30 22:19:47]

On 2015/09/30 21:28:06, sky wrote:
> Whenever I look at this code I get confused. It seems like we have far too
many
> functions here that aren't grouped in meaningful way. For example, why do we
> need the Notify functions to be public? Similarly why is StartShutdownTracing
> here? Can it be called at the right time by this code?
> 
> Can you take this opportunity to cleanup this code and call sites?

Ya, this code is a big pile of... stuff. I'll take another stab at better
organizing it.

[Lei Zhang, 2015-09-30 23:58:24]

I will in fact close this and work on splitting application_lifetime.cc in
smaller pieces. With this as a reference for what goes where.