Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1382553002: Blink gardening: mark printing and virtual/printings tests as failure on Win10. (Closed)

Created:
5 years, 2 months ago by tasak
Modified:
5 years, 2 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blink gardening: mark printing and virtual/printings tests as failure on Win10. BUG=537535 TBR=gavinp@chromium.org NOTRY=true Committed: https://crrev.com/a28bf20c9215ce7a32177ba98d6720b0d81dd48a Cr-Commit-Position: refs/heads/master@{#351518}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382553002/1
5 years, 2 months ago (2015-09-30 08:17:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 08:22:29 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a28bf20c9215ce7a32177ba98d6720b0d81dd48a Cr-Commit-Position: refs/heads/master@{#351518}
5 years, 2 months ago (2015-09-30 08:23:10 UTC) #4
tasak
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1377113002/ by tasak@google.com. ...
5 years, 2 months ago (2015-09-30 08:45:02 UTC) #5
Yuta Kitamura
5 years, 2 months ago (2015-09-30 09:22:12 UTC) #6
Message was sent while issue was closed.
Didn't you get a warning when you upload a CL? I thought you should.

If not, then Blink's PRESUBMIT.py might have not been executed, probably 
due to the Blink-Chromium merge.

Powered by Google App Engine
This is Rietveld 408576698