Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1382533003: Add flag which moves super initializer statement (Closed)

Created:
5 years, 2 months ago by hausner
Modified:
5 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add flag which moves super initializer statement --move_super directs the VM compiler to move the super initializer of a constructor to the end of the initializer list. The default value is false. If we opt to enable this functionality, the implicit phase parameter of constructors can be eliminated, simplifying constructors significantly. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/019a4e4e5cf5e43bd47f5178c82907dd66dfc4fd

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -26 lines) Patch
M runtime/vm/parser.h View 1 chunk +9 lines, -6 lines 0 comments Download
M runtime/vm/parser.cc View 1 8 chunks +63 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
hausner
5 years, 2 months ago (2015-10-07 16:29:11 UTC) #2
regis
lgtm https://codereview.chromium.org/1382533003/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/1382533003/diff/1/runtime/vm/parser.cc#newcode2767 runtime/vm/parser.cc:2767: if (FLAG_move_super && super_init_call != NULL && !super_init_is_last) ...
5 years, 2 months ago (2015-10-07 16:54:44 UTC) #3
hausner
Committed patchset #2 (id:20001) manually as 019a4e4e5cf5e43bd47f5178c82907dd66dfc4fd (presubmit successful).
5 years, 2 months ago (2015-10-07 17:26:42 UTC) #4
hausner
5 years, 2 months ago (2015-10-07 17:27:22 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1382533003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1382533003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:2767: if (FLAG_move_super && super_init_call != NULL &&
!super_init_is_last) {
On 2015/10/07 16:54:43, regis wrote:
> parenthesis missing

Done.

Powered by Google App Engine
This is Rietveld 408576698