Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: src/property-details.h

Issue 1382513003: Test for var declarations in eval which conflict with let (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: mask out eval bit Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parser.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/property-details.h
diff --git a/src/property-details.h b/src/property-details.h
index ca37927017828019bb1972b2846920d3a63339b7..7e5c78b8d98bf03e465bbf5b5e06ae7bad827610 100644
--- a/src/property-details.h
+++ b/src/property-details.h
@@ -11,23 +11,28 @@
// Ecma-262 3rd 8.6.1
enum PropertyAttributes {
- NONE = v8::None,
- READ_ONLY = v8::ReadOnly,
- DONT_ENUM = v8::DontEnum,
- DONT_DELETE = v8::DontDelete,
+ NONE = v8::None,
+ READ_ONLY = v8::ReadOnly,
+ DONT_ENUM = v8::DontEnum,
+ DONT_DELETE = v8::DontDelete,
- SEALED = DONT_DELETE,
- FROZEN = SEALED | READ_ONLY,
+ SEALED = DONT_DELETE,
+ FROZEN = SEALED | READ_ONLY,
- STRING = 8, // Used to filter symbols and string names
- SYMBOLIC = 16,
- PRIVATE_SYMBOL = 32,
+ STRING = 8, // Used to filter symbols and string names
+ SYMBOLIC = 16,
+ PRIVATE_SYMBOL = 32,
- DONT_SHOW = DONT_ENUM | SYMBOLIC | PRIVATE_SYMBOL,
- ABSENT = 64 // Used in runtime to indicate a property is absent.
+ DONT_SHOW = DONT_ENUM | SYMBOLIC | PRIVATE_SYMBOL,
+ ABSENT = 64, // Used in runtime to indicate a property is absent.
// ABSENT can never be stored in or returned from a descriptor's attributes
// bitfield. It is only used as a return value meaning the attributes of
// a non-existent property.
+
+ // When creating a property, EVAL_DECLARED used to indicate that the property
+ // came from a sloppy-mode direct eval, and certain checks need to be done.
+ // Cannot be stored in or returned from a descriptor's attributes bitfield.
+ EVAL_DECLARED = 128
};
« no previous file with comments | « src/parser.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698