Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 1382513002: Regression: 'Alt+Shift+i', shortcut key for "report an issue" works only once for every 2 tries. (Closed)

Created:
5 years, 2 months ago by shiva.jm
Modified:
5 years, 2 months ago
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Regression: 'Alt+Shift+i', shortcut key for "report an issue" works only once for every 2 tries. After deprecation of MediaStream stop() method, we should use screenshotStream.getVideoTracks()[0].stop(), instead of screenshotStream.stop() BUG=536659 Committed: https://crrev.com/4b3425394c2c00fd238baff8e0515d24385c743d Cr-Commit-Position: refs/heads/master@{#351551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/feedback/js/take_screenshot.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
shiva.jm
pls have a look.
5 years, 2 months ago (2015-09-30 05:07:00 UTC) #2
philipj_slow
Non-owner LGTM
5 years, 2 months ago (2015-09-30 07:58:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382513002/1
5 years, 2 months ago (2015-09-30 08:15:31 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 09:12:24 UTC) #7
tommi (sloooow) - chröme
lgtm. I think you still need an owner though.
5 years, 2 months ago (2015-09-30 10:19:14 UTC) #8
shiva.jm
5 years, 2 months ago (2015-09-30 10:47:55 UTC) #10
rkc
lgtm
5 years, 2 months ago (2015-09-30 13:48:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382513002/1
5 years, 2 months ago (2015-09-30 14:30:02 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 14:36:00 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 14:36:48 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b3425394c2c00fd238baff8e0515d24385c743d
Cr-Commit-Position: refs/heads/master@{#351551}

Powered by Google App Engine
This is Rietveld 408576698