url: Copy 'googleurl_unittests' target from 'url_unittests'. Third attempt.

url: Copy 'googleurl_unittests' target from 'url_unittests'. Third attempt.

To not break the buildbot, this creates a fake target that copies url_unittests
to googleurl_unittests as temporary scaffolding.

BUG=229660
R=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196507

[tfarina, 2013-04-24 02:23:08]

Bots seems to be happy with this now.

Thanks Nico for the hard work on getting back the clang roll!

Brett, please review!

Thanks,

[tfarina, 2013-04-25 11:26:03]

Brett, ping?

[brettw, 2013-04-25 18:01:06]

lgtm

[tfarina, 2013-04-25 21:42:01]

Committed patchset #1 manually as r196507 (presubmit successful).

[stuartmorgan, 2013-05-02 17:05:10]

Please don't add iOS-only special-casing without having anyone familiar with iOS
on the review. Anyone doing iOS work could have told you this wouldn't work.

[tfarina, 2013-05-02 17:45:59]

On 2013/05/02 17:05:10, stuartmorgan wrote:
> Please don't add iOS-only special-casing without having anyone familiar with
iOS
> on the review. Anyone doing iOS work could have told you this wouldn't work.

Sorry for any breakage that could have caused. But could you be more specific?
ios_dbg_simulator and ios_rel_device are green. Doesn't that cover iOS case?

[iannucci1, 2013-05-02 22:31:00]

@stuartmorgan, do you know how we could get this working correctly (or someone
else with a ready knowledge of the ios who could help out)?

[iannucci1, 2013-05-02 22:32:02]

On 2013/05/02 22:31:00, iannucci1 wrote:
> @stuartmorgan, do you know how we could get this working correctly (or someone
> else with a ready knowledge of the ios who could help out)?

s/the ios/the ios build/

[stuartmorgan, 2013-05-03 06:58:40]

On 2013/05/02 17:45:59, tfarina wrote:
> ios_dbg_simulator and ios_rel_device are green. Doesn't that cover iOS case?

You created submarine bustage (I thought you were CC'd on a bug where someone
mentioned that try iOS bots were now failing this test). Machines that are green
are green because they haven't been clobbered and still have the old
googleurl_unittests.app.

As soon as a machine is clobbered there's no more .app, and everything breaks,
because all you copy is the executable on iOS and alone that's useless. That's
why iOS try bots are having problems.

lliabraa was trying to clean this up yesterday; I'm not sure how far he got.

[stuartmorgan, 2013-05-03 06:59:13]

On 2013/05/02 22:32:02, iannucci1 wrote:
> On 2013/05/02 22:31:00, iannucci1 wrote:
> > @stuartmorgan, do you know how we could get this working correctly (or
someone
> > else with a ready knowledge of the ios who could help out)?
> 
> s/the ios/the ios build/

Either copy the whole .app (we build it as an app for a reason), or just have
the bots run url_unittests instead.