Translate: browser test to verify whole translate process

Translate: browser test to verify whole translate process

BUG=none
TEST=browser_tests --gtest_filter='TranslateBrowserTest.Translate'

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196587

[Takashi Toyoshima, 2013-04-23 07:37:14]

Hi mad,

Can you review this change?
This test emulates whole translate process including server side script loading.
It must be useful to have this test even though we don't support CSP.

This test can reproduce CSP problem by setting CSP policy in fr_test.html. So we
can easily modify it to verify CSP support once main change is granted.

Thanks.

[MAD, 2013-04-25 14:01:00]

Sorry about the delay, I've been busy with Beta fires in 1993...

This is really cool, thanks a lot for doing this...

I only have a small comment/suggestion/question...

LGTM for the rest!

BYE
MAD

[MAD, 2013-04-25 14:01:17]

With the comment this time... :-)

https://codereview.chromium.org/13825006/diff/5001/chrome/browser/translate/t...
File chrome/browser/translate/translate_browsertest.cc (right):

https://codereview.chromium.org/13825006/diff/5001/chrome/browser/translate/t...
chrome/browser/translate/translate_browsertest.cc:45:
ASSERT_TRUE(https_server_.Start());
Why is this in SetUpCommandLine? Why not in SetUpInProcessBrowserTestFixture?

[MAD, 2013-04-25 14:01:36]

Still LGTM...

[Takashi Toyoshima, 2013-04-25 14:44:07]

Thanks!

https://codereview.chromium.org/13825006/diff/5001/chrome/browser/translate/t...
File chrome/browser/translate/translate_browsertest.cc (right):

https://codereview.chromium.org/13825006/diff/5001/chrome/browser/translate/t...
chrome/browser/translate/translate_browsertest.cc:45:
ASSERT_TRUE(https_server_.Start());
In this change, it can be placed in SetUpInProcessBrowserTestFixture. But, once
we go to use an isolated world, This test needs to add a command line parameter
to specify isolated world origin which depends on server listening port. The
port is decided randomly at run-time. So, I need to launch the server here.

But, in this change, it must be better to place in
SetUpInProcessBrowserTestFixture. I fix this.

https://codereview.chromium.org/13825006/diff/18002/chrome/browser/translate/...
File chrome/browser/translate/translate_browsertest.cc (right):

https://codereview.chromium.org/13825006/diff/18002/chrome/browser/translate/...
chrome/browser/translate/translate_browsertest.cc:79: ASSERT_EQ(0U,
infobar_service->infobar_count());
Wow. method names are changed.

[commit-bot: I haz the power, 2013-04-25 14:44:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/13825006/18002

[commit-bot: I haz the power, 2013-04-25 14:44:25]

Presubmit check for 13825006-18002 failed and returned exit status 1.

INFO:root:Found 6 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit Warnings **
License must match:
.*? Copyright (\(c\) )?(2013|2012|2011|2010|2009|2008|2007|2006|2006-2008) The
Chromium Authors\. All rights reserved\.\n.*? Use of this source code is
governed by a BSD-style license that can be\n.*? found in the LICENSE file\.(?:
\*/)?\n
Found a bad license header in these files:
  chrome/test/data/translate/pseudo_element_main.js \
  chrome/test/data/translate/pseudo_main.js

[commit-bot: I haz the power, 2013-04-25 14:50:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/13825006/16003

[commit-bot: I haz the power, 2013-04-25 16:01:08]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-25 16:28:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/13825006/20004

[commit-bot: I haz the power, 2013-04-25 17:32:27]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-25 23:58:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/13825006/30001

[commit-bot: I haz the power, 2013-04-26 03:42:44]

Change committed as 196587