Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 1382443002: remove unused Debug::has_break_points_ (Closed)

Created:
5 years, 2 months ago by ofrobots
Modified:
5 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

remove unused Debug::has_break_points_ Previous debug refactoring changes removed uses of has_break_points_, but omitted removing the field itself. This is not necessary anymore. R=yangguo@chromium.org BUG= Committed: https://crrev.com/759591dae7adeee646b0c4296066eb7f3844bf39 Cr-Commit-Position: refs/heads/master@{#31016}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/debug/debug.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
ofrobots
5 years, 2 months ago (2015-09-30 01:18:51 UTC) #1
Yang
On 2015/09/30 01:18:51, ofrobots wrote: lgtm
5 years, 2 months ago (2015-09-30 01:22:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382443002/1
5 years, 2 months ago (2015-09-30 05:39:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 06:02:21 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 06:02:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/759591dae7adeee646b0c4296066eb7f3844bf39
Cr-Commit-Position: refs/heads/master@{#31016}

Powered by Google App Engine
This is Rietveld 408576698