Issue 1382433003: Revert "Leak per-isolate data in pdfium"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1382433003: Revert "Leak per-isolate data in pdfium" (Closed)

Created:
5 years, 2 months ago by raymes

Modified:
5 years, 2 months ago

Reviewers:
Lei Zhang, jochen (gone - plz use gerrit)

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Leak per-isolate data in pdfium" This reverts commit 3e144b8c23d7c52ed36329e87f0cb01f38ec1ed7. This may be causing the failures seen in crbug.com/537799. BUG=537799 Committed: https://pdfium.googlesource.com/pdfium/+/953f5c5f3858ce20ea5f28e0045c201148fba036

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	fpdfsdk/src/javascript/JS_Runtime.cpp	View		1 chunk	+1 line, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

raymes

thestig: If you're able to give me commit rights I can land this. I signed ...

5 years, 2 months ago (2015-10-01 03:12:28 UTC) #3

raymes

5 years, 2 months ago (2015-10-01 05:12:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
953f5c5f3858ce20ea5f28e0045c201148fba036 (presubmit successful).