Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 13824006: Make a metaprogramming hack more C++11-compatible (Closed)

Created:
7 years, 8 months ago by Nico
Modified:
7 years, 8 months ago
Reviewers:
yurys
CC:
blink-reviews, loislo
Visibility:
Public.

Description

Make a metaprogramming hack more C++11-compatible Some classes have private "operator delete"s, which causes their destructors to be deleted in C++11. Clang's r178563 implemented this rule better, and as a result using these classes with memory instrumentation causes a compile error. To unblock the clang roll, give the metaprogramming helper class an explicit nondeleted destructor. (This is just a workaround, not a permanent fix, see bug.) See also http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20130415/078311.html BUG=233473 TEST=Stuff still builds in C++11 mode after the next clang roll. TBR=yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148704

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M Source/wtf/MemoryInstrumentation.h View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
r?
7 years, 8 months ago (2013-04-18 22:50:02 UTC) #1
Nico
yurys: Since you reviewed https://bugs.webkit.org/show_bug.cgi?id=105026 can you review this too if nobody beats you to ...
7 years, 8 months ago (2013-04-18 23:11:01 UTC) #2
Nico
I'll TBR this, as it's a build fix.
7 years, 8 months ago (2013-04-19 04:40:57 UTC) #3
Nico
Committed patchset #2 manually as r148704 (presubmit successful).
7 years, 8 months ago (2013-04-19 04:41:21 UTC) #4
yurys
I guess adding explicit ~Base() destructor without implementation should fix problem on Windows.
7 years, 8 months ago (2013-04-19 08:44:18 UTC) #5
yurys
7 years, 8 months ago (2013-04-19 09:30:20 UTC) #6
Message was sent while issue was closed.
On 2013/04/19 08:44:18, Yury Semikhatsky wrote:
> I guess adding explicit ~Base() destructor without implementation should fix
> problem on Windows.

Created a patch wit such fix: https://codereview.chromium.org/14241017/

Powered by Google App Engine
This is Rietveld 408576698