third_party/WebKit/Source/core/dom/StyleEngine.cpp - Issue 1382353002: Oilpan: promptly dispose style resolvers upon clearing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/StyleEngine.cpp

Issue 1382353002: Oilpan: promptly dispose style resolvers upon clearing. Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/StyleEngine.cpp

diff --git a/third_party/WebKit/Source/core/dom/StyleEngine.cpp b/third_party/WebKit/Source/core/dom/StyleEngine.cpp

index 911f80a8e9fae0bf945bcae6ae0992cfaf416e35..e201502114a703038bbd94c447ff06f95fe4886b 100644

--- a/third_party/WebKit/Source/core/dom/StyleEngine.cpp

+++ b/third_party/WebKit/Source/core/dom/StyleEngine.cpp

@@ -427,6 +427,9 @@ void StyleEngine::clearResolver()

if (m_resolver) {

TRACE_EVENT1("blink", "StyleEngine::clearResolver", "frame", document().frame());

+#if ENABLE(OILPAN)

haraken 2015/10/08 06:15:46 Add a comment about why we need to call dispose ex

+ m_resolver->dispose();

+#endif

m_resolver.clear();

}