Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 1382283003: [sql] Use memory-mapped I/O for sql::Connection. (Closed)

Created:
5 years, 2 months ago by Scott Hess - ex-Googler
Modified:
5 years, 2 months ago
Reviewers:
rmcilroy, pavely
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Use memory-mapped I/O for sql::Connection. sql::Connection::Open*() uses PRAGMA mmap_size to enable SQLite's memory-mapped I/O. Additionally instrument to flush dirty pages from the page cache after writes. BUG=489784, 533682, 537681, 537636 [Relands https://crrev.com/9a1948a4d6d4 (#350362), reverted at https://crrev.com/55c3216b15ce (#350386), relanded at https://crrev.com/5c2f4e50d96d (#351344), reverted at https://crrev.com/745e18c52384 (#351596). May the waterfall have mercy on my CL.] Committed: https://crrev.com/7dbd4dee4702e30efb24c81898ae45dd0d502c41 Cr-Commit-Position: refs/heads/master@{#352631}

Patch Set 1 #

Patch Set 2 : Disable mmap test under mojo. #

Patch Set 3 : Fix uninit vars in Connection. #

Patch Set 4 : Check for open db before releasing cache. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -0 lines) Patch
M sql/connection.h View 3 chunks +20 lines, -0 lines 0 comments Download
M sql/connection.cc View 1 2 3 6 chunks +98 lines, -0 lines 1 comment Download
M sql/connection_unittest.cc View 1 2 chunks +80 lines, -0 lines 0 comments Download
M sql/statement.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M sync/syncable/directory_backing_store.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (2 generated)
Scott Hess - ex-Googler
Disable mmap test under mojo.
5 years, 2 months ago (2015-10-02 23:23:52 UTC) #1
Scott Hess - ex-Googler
Fix uninit vars in Connection.
5 years, 2 months ago (2015-10-02 23:24:18 UTC) #2
Scott Hess - ex-Googler
Check for open db before releasing cache.
5 years, 2 months ago (2015-10-02 23:24:47 UTC) #3
Scott Hess - ex-Googler
https://codereview.chromium.org/1349863003/, slipstream https://codereview.chromium.org/1355403004/ to fix mojo test, slipstream https://codereview.chromium.org/1368493002/ to fix valgrind complaint, slipstream https://codereview.chromium.org/1381563003/ ...
5 years, 2 months ago (2015-10-02 23:36:54 UTC) #4
Scott Hess - ex-Googler
On 2015/10/02 23:36:54, Scott Hess wrote: > https://codereview.chromium.org/1349863003/, slipstream > https://codereview.chromium.org/1355403004/ to fix mojo test, ...
5 years, 2 months ago (2015-10-02 23:38:15 UTC) #5
Scott Hess - ex-Googler
Back for more! pavely@ no changes to what you previously LGTM'ed in sync. rmcilroy@ ps4 ...
5 years, 2 months ago (2015-10-02 23:42:44 UTC) #7
pavely
sync/* lgtm
5 years, 2 months ago (2015-10-02 23:48:30 UTC) #8
rmcilroy
lgtm.
5 years, 2 months ago (2015-10-06 10:29:19 UTC) #9
Scott Hess - ex-Googler
On 2015/10/06 10:29:19, rmcilroy wrote: > lgtm. Thanks. I think the trybot failures were all ...
5 years, 2 months ago (2015-10-06 16:24:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382283003/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382283003/50001
5 years, 2 months ago (2015-10-06 16:25:05 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:50001)
5 years, 2 months ago (2015-10-06 17:39:25 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 17:40:15 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/7dbd4dee4702e30efb24c81898ae45dd0d502c41
Cr-Commit-Position: refs/heads/master@{#352631}

Powered by Google App Engine
This is Rietveld 408576698