Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json

Issue 1382203002: bot_update (+recipe_module): treat patch download as infra failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: 87! Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json
diff --git a/scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json b/scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json
similarity index 78%
copy from scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json
copy to scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json
index 69f65f215be8ee9d18128ea44f41fd6ea0b15ed3..6ed16f4f477d22bc62f087a60661453898e0cdfc 100644
--- a/scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json
+++ b/scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch_download.json
@@ -35,6 +35,7 @@
"@@@STEP_LOG_LINE@json.output@ \"Patch failed to apply\"@@@",
"@@@STEP_LOG_LINE@json.output@ ]@@@",
"@@@STEP_LOG_LINE@json.output@ ], @@@",
+ "@@@STEP_LOG_LINE@json.output@ \"patch_apply_return_code\": 3, @@@",
"@@@STEP_LOG_LINE@json.output@ \"patch_failure\": true, @@@",
"@@@STEP_LOG_LINE@json.output@ \"patch_root\": \"src\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"properties\": {}, @@@",
@@ -43,27 +44,12 @@
"@@@STEP_LOG_LINE@json.output@}@@@",
"@@@STEP_LOG_END@json.output@@@",
"@@@STEP_LOG_LINE@patch error@Patch failed to apply@@@",
- "@@@STEP_LOG_END@patch error@@@",
- "@@@SET_BUILD_PROPERTY@failure_type@\"PATCH_FAILURE\"@@@"
- ]
- },
- {
- "cmd": [
- "python",
- "-u",
- "import sys; sys.exit(1)"
- ],
- "cwd": "[SLAVE_BUILD]",
- "name": "Patch failure",
- "~followup_annotations": [
- "step returned non-zero exit code: 1",
- "@@@STEP_TEXT@Check the bot_update step for details@@@",
- "@@@STEP_FAILURE@@@"
+ "@@@STEP_LOG_END@patch error@@@"
]
},
{
"name": "$final_result",
- "reason": "Step('Patch failure') failed with return_code 1",
+ "reason": "Failed to download the patch",
"status_code": 1
}
]

Powered by Google App Engine
This is Rietveld 408576698