scripts/slave/recipe_modules/bot_update/example.py - Issue 1382203002: bot_update (+recipe_module): treat patch download as infra failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/bot_update/example.py

Issue 1382203002: bot_update (+recipe_module): treat patch download as infra failure. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: NBits\ Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/bot_update/api.py ('k') | scripts/slave/recipe_modules/bot_update/example.expected/tryjob_fail_patch.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/bot_update/example.py

diff --git a/scripts/slave/recipe_modules/bot_update/example.py b/scripts/slave/recipe_modules/bot_update/example.py

index 7997900b2adddce0466cf25c4f4b4488e7404df1..f191f463cffaa3070c069911317334964dfb2be0 100644

--- a/scripts/slave/recipe_modules/bot_update/example.py

+++ b/scripts/slave/recipe_modules/bot_update/example.py

@@ -83,8 +83,17 @@ def GenTests(api):

issue=12345,

patchset=654321,

patch_url='http://src.chromium.org/foo/bar',

- fail_patch=True,

+ fail_patch='apply',

) + api.step_data('bot_update', retcode=88)

+ yield api.test('tryjob_fail_patch_download') + api.properties(

+ mastername='tryserver.chromium.linux',

+ buildername='linux_rel',

+ slavename='totallyaslave-c4',

+ issue=12345,

+ patchset=654321,

+ patch_url='http://src.chromium.org/foo/bar',

+ fail_patch='download'

+ ) + api.step_data('bot_update', retcode=87)

yield api.test('forced') + api.properties(

mastername='experimental',

buildername='Experimental Builder',