bot_update (+recipe_module): treat patch download as infra failure.

scripts/slave/bot_update.py

Index: scripts/slave/bot_update.py
diff --git a/scripts/slave/bot_update.py b/scripts/slave/bot_update.py
index 1a2e5974c9b4f7ffd237ee1fb8032cf15b71151d..e6904ee9921898d8bfb81caab728b6e6b8dbbfb5 100755
--- a/scripts/slave/bot_update.py
+++ b/scripts/slave/bot_update.py
@@ -1580,6 +1580,7 @@ def checkout(options, git_slns, specs, buildspec, master,
                 did_run=True,
                 root=first_sln,
                 log_lines=[('patch error', e.output),],
+                return_code=e.code,
                 patch_root=options.patch_root,
                 patch_failure=True,
                 step_text='%s PATCH FAILED' % step_text)
@@ -1680,12 +1681,17 @@ def main():
   except Inactive:
     # Not active, should count as passing.
     pass
-  except PatchFailed:
+  except PatchFailed as e:
     emit_flag(options.flag_file)
     # Return a specific non-zero exit code for patch failure (because it is
     # a failure), but make it different than other failures to distinguish
     # between infra failures (independent from patch author), and patch
-    # failures (that patch author can fix).
+    # failures (that patch author can fix). However, PatchFailure due to
+    # download patch failure is still an infra problem.
+    if e.code == 89:

[Sergiy Byelozyorov, 2015/10/02 11:50:25]

According to changes in other patch - change this to 2, but leave 89 below as
is.

[tandrii(chromium), 2015/10/02 12:38:25]

Done.

+      # Patch download problem.
+      return 89
+    # Genuine patch problem.
     return 88
   except Exception:
     # Unexpected failure.