Split SVGFilterbuilder into "builder" and "node map" parts

third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceFilter.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005 Rob Buis <buis@kde.org>
  * Copyright (C) 2005 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 #include "core/layout/svg/LayoutSVGResourceFilter.h"
 
-#include "core/dom/ElementTraversal.h"
 #include "core/svg/SVGFilterPrimitiveStandardAttributes.h"
-#include "platform/graphics/GraphicsContext.h"
-#include "platform/graphics/filters/SourceGraphic.h"
-#include "third_party/skia/include/core/SkPicture.h"
 
 namespace blink {
 
 DEFINE_TRACE(FilterData)
 {
 #if ENABLE(OILPAN)
     visitor->trace(filter);
-    visitor->trace(builder);
+    visitor->trace(nodeMap);
 #endif
 }
 
 void FilterData::dispose()
 {
-    builder = nullptr;
+    nodeMap = nullptr;
     filter = nullptr;
 }
 
 LayoutSVGResourceFilter::LayoutSVGResourceFilter(SVGFilterElement* node)
     : LayoutSVGResourceContainer(node)
 {
 }
 
 LayoutSVGResourceFilter::~LayoutSVGResourceFilter()
 {
@@ skipping 36 matching lines @@
     if (filterCached)
         m_filter.remove(client);
 
     // If the filter has a cached subtree, invalidate the associated display item.
     if (markForInvalidation && filterCached)
         markClientForInvalidation(client, PaintInvalidation);
 
     markClientForInvalidation(client, markForInvalidation ? BoundariesInvalidation : ParentOnlyInvalidation);
 }
 
-PassRefPtrWillBeRawPtr<SVGFilterBuilder> LayoutSVGResourceFilter::buildPrimitives(Filter* filter)
-{
-    SVGFilterElement* filterElement = toSVGFilterElement(element());
-    FloatRect referenceBox = filter->referenceBox();
-
-    // Add effects to the builder
-    RefPtrWillBeRawPtr<SVGFilterBuilder> builder = SVGFilterBuilder::create(filter->sourceGraphic());
-    for (SVGElement* element = Traversal<SVGElement>::firstChild(*filterElement); element; element = Traversal<SVGElement>::nextSibling(*element)) {
-        if (!element->isFilterEffect() || !element->layoutObject())
-            continue;
-
-        SVGFilterPrimitiveStandardAttributes* effectElement = static_cast<SVGFilterPrimitiveStandardAttributes*>(element);
-        RefPtrWillBeRawPtr<FilterEffect> effect = effectElement->build(builder.get(), filter);
-        if (!effect) {
-            builder->clearEffects();
-            return nullptr;
-        }
-        builder->appendEffectToEffectReferences(effect, effectElement->layoutObject());
-        effectElement->setStandardAttributes(effect.get());
-        effect->setEffectBoundaries(SVGLengthContext::resolveRectangle<SVGFilterPrimitiveStandardAttributes>(effectElement, filterElement->primitiveUnits()->currentValue()->enumValue(), referenceBox));
-        effect->setOperatingColorSpace(
-            effectElement->layoutObject()->style()->svgStyle().colorInterpolationFilters() == CI_LINEARRGB ? ColorSpaceLinearRGB : ColorSpaceDeviceRGB);
-        builder->add(AtomicString(effectElement->result()->currentValue()->value()), effect);
-    }
-    filter->setLastEffect(builder->lastEffect());
-    return builder.release();
-}
-
 FloatRect LayoutSVGResourceFilter::resourceBoundingBox(const LayoutObject* object)
 {
     if (SVGFilterElement* element = toSVGFilterElement(this->element()))
         return SVGLengthContext::resolveRectangle<SVGFilterElement>(element, element->filterUnits()->currentValue()->enumValue(), object->objectBoundingBox());
 
     return FloatRect();
 }
 
 void LayoutSVGResourceFilter::primitiveAttributeChanged(LayoutObject* object, const QualifiedName& attribute)
 {
-    FilterMap::iterator it = m_filter.begin();
-    FilterMap::iterator end = m_filter.end();
     SVGFilterPrimitiveStandardAttributes* primitive = static_cast<SVGFilterPrimitiveStandardAttributes*>(object->node());
 
-    for (; it != end; ++it) {
-        FilterData* filterData = it->value.get();
+    for (auto& filter : m_filter) {
+        FilterData* filterData = filter.value.get();
         if (filterData->m_state != FilterData::ReadyToPaint)
             continue;
 
-        SVGFilterBuilder* builder = filterData->builder.get();
-        FilterEffect* effect = builder->effectByRenderer(object);
+        SVGFilterGraphNodeMap* nodeMap = filterData->nodeMap.get();
+        FilterEffect* effect = nodeMap->effectByRenderer(object);
         if (!effect)
             continue;
         // Since all effects shares the same attribute value, all
         // or none of them will be changed.
         if (!primitive->setFilterEffectAttribute(effect, attribute))
             return;
-        builder->clearResultsRecursive(effect);
+        nodeMap->invalidateDependentEffects(effect);
 
         // Issue paint invalidations for the image on the screen.
-        markClientForInvalidation(it->key, PaintInvalidation);
+        markClientForInvalidation(filter.key, PaintInvalidation);
     }
     markAllClientLayersForInvalidation();
 }
 
 } // namespace blink