Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1382143005: Limit hints on empty hide on package imports. (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -40 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 3 chunks +12 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 4 chunks +5 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart View 1 chunk +15 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 3 chunks +30 lines, -12 lines 0 comments Download
A tests/compiler/dart2js/combinator_hint_test.dart View 1 chunk +98 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Johnni Winther
Main change in library_loader.dart and apiimpl.dart.
5 years, 2 months ago (2015-10-06 12:45:30 UTC) #2
sigurdm
LGTM
5 years, 2 months ago (2015-10-06 13:01:58 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as e49a3e7d4449874d55fefce9cc8601e9f212e847 (presubmit successful).
5 years, 2 months ago (2015-10-06 13:13:21 UTC) #4
nweiz
On 2015/10/06 13:13:21, Johnni Winther wrote: > Committed patchset #1 (id:1) manually as > e49a3e7d4449874d55fefce9cc8601e9f212e847 ...
5 years, 2 months ago (2015-10-06 22:18:15 UTC) #5
Johnni Winther
On 2015/10/06 22:18:15, nweiz wrote: > On 2015/10/06 13:13:21, Johnni Winther wrote: > > Committed ...
5 years, 2 months ago (2015-10-07 07:50:46 UTC) #6
nweiz
5 years, 2 months ago (2015-10-09 19:49:54 UTC) #7
Message was sent while issue was closed. 
On 2015/10/07 07:50:46, Johnni Winther wrote:
> On 2015/10/06 22:18:15, nweiz wrote:
> > On 2015/10/06 13:13:21, Johnni Winther wrote:
> > > Committed patchset #1 (id:1) manually as
> > > e49a3e7d4449874d55fefce9cc8601e9f212e847 (presubmit successful).
> > 
> > As of 6584580d8f0d181749a5e1dd2883946af886c316, I'm still seeing warnings
for
> > this import:
> >
>
https://github.com/dart-lang/test/blob/master/lib/src/util/forkable_stream.da...
> 
> When are you seeing these _hints_? Do you use the --show-package-warnings
flag?
> Do you expect your users to use it?

Oh, yes, I am, and I shouldn't be.

Powered by Google App Engine
This is Rietveld 408576698