Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 1382123002: Ensure scopes are backed by blocks in the body of for loops (Closed)

Created:
5 years, 2 months ago by Dan Ehrenberg
Modified:
5 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ensure scopes are backed by blocks in the body of for loops Clusterfuzz testing discovered that sloppy-mode block-scoped function declarations introduce lexically-scoped variables in scopes that were thrown away under the expectation that no lexically-scoped variables were introduced. These cases are: for (;;) function foo() {} for (x in y) function foo() {} This patch ensures that a block is created in those cases to hold the lexically scoped variable. Usually, scope analysis should discover that that block is not important, and it should not have a runtime representation. BUG=chromium:536750, chromium:536751 LOG=Y R=adamk Committed: https://crrev.com/2d4085622a46a700779a2e251caae8a1833c34a6 Cr-Commit-Position: refs/heads/master@{#31109}

Patch Set 1 #

Patch Set 2 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M src/parser.cc View 1 2 chunks +21 lines, -4 lines 0 comments Download
A test/mjsunit/regress/regress-536751.js View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382123002/1
5 years, 2 months ago (2015-10-02 01:31:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382123002/20001
5 years, 2 months ago (2015-10-02 02:32:07 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-02 02:54:40 UTC) #7
Dan Ehrenberg
5 years, 2 months ago (2015-10-02 02:58:11 UTC) #8
adamk
lgtm
5 years, 2 months ago (2015-10-05 17:41:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382123002/20001
5 years, 2 months ago (2015-10-05 17:55:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-05 18:52:54 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 18:53:06 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d4085622a46a700779a2e251caae8a1833c34a6
Cr-Commit-Position: refs/heads/master@{#31109}

Powered by Google App Engine
This is Rietveld 408576698