Issue 1382073002: Disable JBIG2 cache; prevent data corruption

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1382073002: Disable JBIG2 cache; prevent data corruption (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
jbreiden

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Disable JBIG2 cache; prevent data corruption BUG=pdfium:207 Original author: jbreiden@google.com Original CL: http://codereview.chromium.org/1362133003/ R=jbreiden@google.com Committed: https://pdfium.googlesource.com/pdfium/+/7886d8dcf3bc9ef9b51e733d77bd3243ef32adb8

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	core/src/fxcodec/jbig2/JBig2_Context.cpp	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lei Zhang

Committed patchset #1 (id:1) manually as 7886d8dcf3bc9ef9b51e733d77bd3243ef32adb8 (presubmit successful).

5 years, 2 months ago (2015-10-01 22:12:53 UTC) #4

Lei Zhang

5 years, 2 months ago (2015-10-04 06:15:37 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/1382073002/diff/1/core/src/fxcodec/jbig2/JBig...
File core/src/fxcodec/jbig2/JBig2_Context.cpp (right):

https://codereview.chromium.org/1382073002/diff/1/core/src/fxcodec/jbig2/JBig...
core/src/fxcodec/jbig2/JBig2_Context.cpp:28: static const int
kSymbolDictCacheMaxSize = 2;
Uh, fail.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages