Issue 1382063002: Subzero. Adds I64 register pairs for ARM32.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1382063002: Subzero. Adds I64 register pairs for ARM32. (Closed)

Created:
5 years, 2 months ago by John

Modified:
5 years, 2 months ago

Reviewers:
Jim Stichnoth, Karl, sehr

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero. Adds I64 register pairs for ARM32. This is in preparation for llvm.nacl.atomic.* lowerings. atomic i64 loads and stores require their operands to be consecutive registers starting at an even register that is not r14. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=ed2c06b20a04fc07f0a54b7ce01f19c98bd5a3ab

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+192 lines, -138 lines)			Patch
M	src/IceInstARM32.def	View	14 chunks	+170 lines, -128 lines	0 comments	Download
M	src/IceRegistersARM32.h	View	6 chunks	+15 lines, -5 lines	0 comments	Download
M	src/IceTargetLoweringARM32.cpp	View	5 chunks	+7 lines, -5 lines	0 comments	Download

Total messages: 7 (2 generated)

John

Committed patchset #2 (id:20001) manually as ed2c06b20a04fc07f0a54b7ce01f19c98bd5a3ab (presubmit successful).

5 years, 2 months ago (2015-10-01 22:27:19 UTC) #6

Message was sent while issue was closed.

also lgtm