Rename a few Member and Persistent methods to make the transition

Source/heap/HeapTest.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 321 matching lines @@
     static Baz* create(Bar* bar)
     {
         return new Baz(bar);
     }
 
     void trace(Visitor* visitor)
     {
         visitor->trace(m_bar);
     }
 
-    void clear() { m_bar.clear(); }
+    void clear() { m_bar.release(); }
 
 private:
     explicit Baz(Bar* bar)
         : m_bar(bar)
     {
     }
 
     Member<Bar> m_bar;
 };
 
@@ skipping 294 matching lines @@
 TEST(HeapTest, TypedHeapSanity)
 {
     // FIXME: init and shutdown should be called via Blink
     // initialization in the test runner.
     Heap::init();
 
     {
         // We use TraceCounter for allocating an object on the general heap.
         Persistent<TraceCounter> generalHeapObject = TraceCounter::create();
         Persistent<TestTypedHeapClass> typedHeapObject = TestTypedHeapClass::create();
-        EXPECT_NE(pageHeaderAddress(reinterpret_cast<Address>(generalHeapObject.raw())),
-            pageHeaderAddress(reinterpret_cast<Address>(typedHeapObject.raw())));
+        EXPECT_NE(pageHeaderAddress(reinterpret_cast<Address>(generalHeapObject.get())),
+            pageHeaderAddress(reinterpret_cast<Address>(typedHeapObject.get())));
     }
 
     Heap::shutdown();
 }
 
 TEST(HeapTest, NoAllocation)
 {
     // FIXME: init and shutdown should be called via Blink
     // initialization in the test runner.
     Heap::init();
@@ skipping 319 matching lines @@
             EXPECT_TRUE(h5->strongIsThere());
             EXPECT_TRUE(h5->weakIsThere());
         }
         // h3 is collected, weak pointers from h4 and h5 don't keep it alive.
         Heap::collectGarbage(ThreadState::NoHeapPointersOnStack);
         EXPECT_EQ(4u, Bar::s_live);
         EXPECT_TRUE(h4->strongIsThere());
         EXPECT_FALSE(h4->weakIsThere()); // h3 is gone from weak pointer.
         EXPECT_TRUE(h5->strongIsThere());
         EXPECT_FALSE(h5->weakIsThere()); // h3 is gone from weak pointer.
-        h1.clear(); // Zero out h1.
+        h1.release(); // Zero out h1.
         Heap::collectGarbage(ThreadState::NoHeapPointersOnStack);
         EXPECT_EQ(3u, Bar::s_live); // Only h4, h5 and h2 are left.
         EXPECT_TRUE(h4->strongIsThere()); // h2 is still pointed to from h4.
         EXPECT_TRUE(h5->strongIsThere()); // h2 is still pointed to from h5.
     }
     // h4 and h5 have gone out of scope now and they were keeping h2 alive.
     Heap::collectGarbage(ThreadState::NoHeapPointersOnStack);
     EXPECT_EQ(0u, Bar::s_live); // All gone.
 
     Heap::shutdown();
 }
 
+TEST(HeapTest, Comparisons)
+{
+    Heap::init();

[haraken, 2014/01/14 13:57:10]

This will be removed in wibling's CL, which is currently in the commit queue.

[Mads Ager (chromium), 2014/01/14 14:03:13]

Yes. I'll wait for Gustav's changes, rebase and put in the cq.

+
+    {
+        Persistent<Bar> barPersistent = Bar::create();
+        Persistent<Foo> fooPersistent = Foo::create(barPersistent);
+        EXPECT_TRUE(barPersistent != fooPersistent);
+        barPersistent = fooPersistent;
+        EXPECT_TRUE(barPersistent == fooPersistent);
+    }
+
+    Heap::shutdown();

[haraken, 2014/01/14 13:57:10]

Ditto.

+}
+
 DEFINE_GC_INFO(Bar);
 DEFINE_GC_INFO(Baz);
 DEFINE_GC_INFO(ClassWithMember);
 DEFINE_GC_INFO(ConstructorAllocation);
 DEFINE_GC_INFO(HeapAllocatedArray);
 DEFINE_GC_INFO(IntWrapper);
 DEFINE_GC_INFO(LargeObject);
 DEFINE_GC_INFO(RefCountedAndGarbageCollected);
 DEFINE_GC_INFO(SimpleFinalizedObject);
 DEFINE_GC_INFO(TestTypedHeapClass);
 DEFINE_GC_INFO(TraceCounter);
 
 } // namespace