Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: lib/src/error_formatter.dart

Issue 1382023002: Support for --fatal-hints. (Closed) Base URL: https://github.com/dart-lang/analyzer_cli.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/analyzer_impl.dart ('k') | lib/src/options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/error_formatter.dart
diff --git a/lib/src/error_formatter.dart b/lib/src/error_formatter.dart
index 2c81ec8e29ca1fbbed18f98f88f6ad022fadd6d5..fe0f00f0a24520c0acb43f559afeded9a93f39ed 100644
--- a/lib/src/error_formatter.dart
+++ b/lib/src/error_formatter.dart
@@ -31,7 +31,7 @@ class ErrorFormatter {
LineInfo_Location location = errorToLine[error].getLocation(error.offset);
int length = error.length;
ErrorSeverity severity =
- AnalyzerImpl.computeSeverity(error, options.enableTypeChecks);
+ AnalyzerImpl.computeSeverity(error, options);
if (options.machineFormat) {
if (severity == ErrorSeverity.WARNING && options.warningsAreFatal) {
severity = ErrorSeverity.ERROR;
@@ -80,9 +80,9 @@ class ErrorFormatter {
errors.sort((AnalysisError error1, AnalysisError error2) {
// Severity.
ErrorSeverity severity1 =
- AnalyzerImpl.computeSeverity(error1, options.enableTypeChecks);
+ AnalyzerImpl.computeSeverity(error1, options);
ErrorSeverity severity2 =
- AnalyzerImpl.computeSeverity(error2, options.enableTypeChecks);
+ AnalyzerImpl.computeSeverity(error2, options);
int compare = severity2.compareTo(severity1);
if (compare != 0) {
return compare;
@@ -103,7 +103,7 @@ class ErrorFormatter {
int lintCount = 0;
for (AnalysisError error in errors) {
ErrorSeverity severity =
- AnalyzerImpl.computeSeverity(error, options.enableTypeChecks);
+ AnalyzerImpl.computeSeverity(error, options);
if (severity == ErrorSeverity.ERROR) {
errorCount++;
} else if (severity == ErrorSeverity.WARNING) {
« no previous file with comments | « lib/src/analyzer_impl.dart ('k') | lib/src/options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698