Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1382013002: Make path range loading explicit (Closed)

Created:
5 years, 2 months ago by Chris Dalton
Modified:
5 years, 2 months ago
Reviewers:
Mark Kilgard, bsalomon
CC:
reviews_skia.org, Kimmo Kinnunen, nv_mark, vbuzinov
Base URL:
https://skia.googlesource.com/skia.git@upload4_cache
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make path range loading explicit Requires the caller to explicitly preload paths within a range before calling drawPaths. This allows us to remove the implicit lazy load, thereby eliminating a redundant check on every redraw of a text blob. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d1201058bf73a0a5c2e19c0cc142082b1827461c

Patch Set 1 #

Patch Set 2 : Fix clang build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -49 lines) Patch
M src/gpu/GrPathRange.h View 1 3 chunks +64 lines, -5 lines 0 comments Download
M src/gpu/GrPathRange.cpp View 2 chunks +13 lines, -43 lines 0 comments Download
M src/gpu/GrPathRendering.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Chris Dalton
5 years, 2 months ago (2015-10-01 17:15:38 UTC) #2
Mark Kilgard
not a well-qualified reviewer, but see no issues
5 years, 2 months ago (2015-10-01 17:46:24 UTC) #4
bsalomon
lgtm
5 years, 2 months ago (2015-10-02 14:43:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382013002/1
5 years, 2 months ago (2015-10-05 22:40:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac10.8-Clang-x86_64-Release-Trybot/builds/5935)
5 years, 2 months ago (2015-10-05 22:41:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382013002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382013002/20001
5 years, 2 months ago (2015-10-05 22:49:54 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 22:56:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d1201058bf73a0a5c2e19c0cc142082b1827461c

Powered by Google App Engine
This is Rietveld 408576698