Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Side by Side Diff: src/heap/mark-compact.cc

Issue 1382003002: [heap] Divide available memory upon compaction tasks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@counters
Patch Set: Rebase + addressed comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/mark-compact.h ('k') | src/heap/spaces.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/mark-compact.h" 5 #include "src/heap/mark-compact.h"
6 6
7 #include "src/base/atomicops.h" 7 #include "src/base/atomicops.h"
8 #include "src/base/bits.h" 8 #include "src/base/bits.h"
9 #include "src/base/sys-info.h" 9 #include "src/base/sys-info.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 548 matching lines...) Expand 10 before | Expand all | Expand 10 after
559 } 559 }
560 560
561 if (heap()->concurrent_sweeping_enabled()) { 561 if (heap()->concurrent_sweeping_enabled()) {
562 pending_sweeper_tasks_semaphore_.Wait(); 562 pending_sweeper_tasks_semaphore_.Wait();
563 pending_sweeper_tasks_semaphore_.Wait(); 563 pending_sweeper_tasks_semaphore_.Wait();
564 pending_sweeper_tasks_semaphore_.Wait(); 564 pending_sweeper_tasks_semaphore_.Wait();
565 } 565 }
566 566
567 ParallelSweepSpacesComplete(); 567 ParallelSweepSpacesComplete();
568 sweeping_in_progress_ = false; 568 sweeping_in_progress_ = false;
569 RefillFreeList(heap()->paged_space(OLD_SPACE)); 569 heap()->old_space()->RefillFreeList();
570 RefillFreeList(heap()->paged_space(CODE_SPACE)); 570 heap()->code_space()->RefillFreeList();
571 RefillFreeList(heap()->paged_space(MAP_SPACE)); 571 heap()->map_space()->RefillFreeList();
572 572
573 #ifdef VERIFY_HEAP 573 #ifdef VERIFY_HEAP
574 if (FLAG_verify_heap && !evacuation()) { 574 if (FLAG_verify_heap && !evacuation()) {
575 VerifyEvacuation(heap_); 575 VerifyEvacuation(heap_);
576 } 576 }
577 #endif 577 #endif
578 } 578 }
579 579
580 580
581 bool MarkCompactCollector::IsSweepingCompleted() { 581 bool MarkCompactCollector::IsSweepingCompleted() {
582 if (!pending_sweeper_tasks_semaphore_.WaitFor( 582 if (!pending_sweeper_tasks_semaphore_.WaitFor(
583 base::TimeDelta::FromSeconds(0))) { 583 base::TimeDelta::FromSeconds(0))) {
584 return false; 584 return false;
585 } 585 }
586 pending_sweeper_tasks_semaphore_.Signal(); 586 pending_sweeper_tasks_semaphore_.Signal();
587 return true; 587 return true;
588 } 588 }
589 589
590 590
591 void MarkCompactCollector::RefillFreeList(PagedSpace* space) {
592 FreeList* free_list;
593
594 if (space == heap()->old_space()) {
595 free_list = free_list_old_space_.get();
596 } else if (space == heap()->code_space()) {
597 free_list = free_list_code_space_.get();
598 } else if (space == heap()->map_space()) {
599 free_list = free_list_map_space_.get();
600 } else {
601 // Any PagedSpace might invoke RefillFreeLists, so we need to make sure
602 // to only refill them for the old space.
603 return;
604 }
605
606 intptr_t added = space->free_list()->Concatenate(free_list);
607 space->accounting_stats_.IncreaseCapacity(added);
608 }
609
610
611 void Marking::TransferMark(Heap* heap, Address old_start, Address new_start) { 591 void Marking::TransferMark(Heap* heap, Address old_start, Address new_start) {
612 // This is only used when resizing an object. 592 // This is only used when resizing an object.
613 DCHECK(MemoryChunk::FromAddress(old_start) == 593 DCHECK(MemoryChunk::FromAddress(old_start) ==
614 MemoryChunk::FromAddress(new_start)); 594 MemoryChunk::FromAddress(new_start));
615 595
616 if (!heap->incremental_marking()->IsMarking()) return; 596 if (!heap->incremental_marking()->IsMarking()) return;
617 597
618 // If the mark doesn't move, we don't check the color of the object. 598 // If the mark doesn't move, we don't check the color of the object.
619 // It doesn't matter whether the object is black, since it hasn't changed 599 // It doesn't matter whether the object is black, since it hasn't changed
620 // size, so the adjustment to the live data count will be zero anyway. 600 // size, so the adjustment to the live data count will be zero anyway.
(...skipping 2769 matching lines...) Expand 10 before | Expand all | Expand 10 after
3390 3370
3391 const int num_tasks = NumberOfParallelCompactionTasks(); 3371 const int num_tasks = NumberOfParallelCompactionTasks();
3392 3372
3393 // Set up compaction spaces. 3373 // Set up compaction spaces.
3394 CompactionSpaceCollection** compaction_spaces_for_tasks = 3374 CompactionSpaceCollection** compaction_spaces_for_tasks =
3395 new CompactionSpaceCollection*[num_tasks]; 3375 new CompactionSpaceCollection*[num_tasks];
3396 for (int i = 0; i < num_tasks; i++) { 3376 for (int i = 0; i < num_tasks; i++) {
3397 compaction_spaces_for_tasks[i] = new CompactionSpaceCollection(heap()); 3377 compaction_spaces_for_tasks[i] = new CompactionSpaceCollection(heap());
3398 } 3378 }
3399 3379
3400 compaction_spaces_for_tasks[0]->Get(OLD_SPACE)->MoveOverFreeMemory( 3380 heap()->old_space()->DivideUponCompactionSpaces(compaction_spaces_for_tasks,
3401 heap()->old_space()); 3381 num_tasks);
3402 compaction_spaces_for_tasks[0] 3382 heap()->code_space()->DivideUponCompactionSpaces(compaction_spaces_for_tasks,
3403 ->Get(CODE_SPACE) 3383 num_tasks);
3404 ->MoveOverFreeMemory(heap()->code_space());
3405 3384
3406 compaction_in_progress_ = true; 3385 compaction_in_progress_ = true;
3407 // Kick off parallel tasks. 3386 // Kick off parallel tasks.
3408 for (int i = 1; i < num_tasks; i++) { 3387 for (int i = 1; i < num_tasks; i++) {
3409 concurrent_compaction_tasks_active_++; 3388 concurrent_compaction_tasks_active_++;
3410 V8::GetCurrentPlatform()->CallOnBackgroundThread( 3389 V8::GetCurrentPlatform()->CallOnBackgroundThread(
3411 new CompactionTask(heap(), compaction_spaces_for_tasks[i]), 3390 new CompactionTask(heap(), compaction_spaces_for_tasks[i]),
3412 v8::Platform::kShortRunningTask); 3391 v8::Platform::kShortRunningTask);
3413 } 3392 }
3414 3393
3415 // Contribute in main thread. Counter and signal are in principal not needed. 3394 // Contribute in main thread. Counter and signal are in principal not needed.
3416 concurrent_compaction_tasks_active_++;
3417 EvacuatePages(compaction_spaces_for_tasks[0], &migration_slots_buffer_); 3395 EvacuatePages(compaction_spaces_for_tasks[0], &migration_slots_buffer_);
3418 pending_compaction_tasks_semaphore_.Signal();
3419 3396
3420 WaitUntilCompactionCompleted(); 3397 WaitUntilCompactionCompleted();
3421 3398
3422 // Merge back memory (compacted and unused) from compaction spaces. 3399 // Merge back memory (compacted and unused) from compaction spaces.
3423 for (int i = 0; i < num_tasks; i++) { 3400 for (int i = 0; i < num_tasks; i++) {
3424 heap()->old_space()->MergeCompactionSpace( 3401 heap()->old_space()->MergeCompactionSpace(
3425 compaction_spaces_for_tasks[i]->Get(OLD_SPACE)); 3402 compaction_spaces_for_tasks[i]->Get(OLD_SPACE));
3426 heap()->code_space()->MergeCompactionSpace( 3403 heap()->code_space()->MergeCompactionSpace(
3427 compaction_spaces_for_tasks[i]->Get(CODE_SPACE)); 3404 compaction_spaces_for_tasks[i]->Get(CODE_SPACE));
3428 delete compaction_spaces_for_tasks[i]; 3405 delete compaction_spaces_for_tasks[i];
(...skipping 1172 matching lines...) Expand 10 before | Expand all | Expand 10 after
4601 MarkBit mark_bit = Marking::MarkBitFrom(host); 4578 MarkBit mark_bit = Marking::MarkBitFrom(host);
4602 if (Marking::IsBlack(mark_bit)) { 4579 if (Marking::IsBlack(mark_bit)) {
4603 RelocInfo rinfo(pc, RelocInfo::CODE_TARGET, 0, host); 4580 RelocInfo rinfo(pc, RelocInfo::CODE_TARGET, 0, host);
4604 RecordRelocSlot(&rinfo, target); 4581 RecordRelocSlot(&rinfo, target);
4605 } 4582 }
4606 } 4583 }
4607 } 4584 }
4608 4585
4609 } // namespace internal 4586 } // namespace internal
4610 } // namespace v8 4587 } // namespace v8
OLDNEW
« no previous file with comments | « src/heap/mark-compact.h ('k') | src/heap/spaces.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698