Issue 13820024: [Android] Thread names reflect the device serial number they are associated with.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13820024: [Android] Thread names reflect the device serial number they are associated with. (Closed)

Created:
7 years, 8 months ago by craigdh

Modified:
7 years, 8 months ago

Reviewers:
frankf

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Thread names reflect the device serial number they are associated with. BUG=160320 TEST=Ran the tests and unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193274

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove python2.7 specific features #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -13 lines)			Patch
M	build/android/pylib/base/shard.py	View		3 chunks	+7 lines, -5 lines	0 comments	Download
M	build/android/pylib/utils/reraiser_thread.py	View	1	2 chunks	+13 lines, -6 lines	0 comments	Download
M	build/android/pylib/utils/run_tests_helper.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

frankf

lgtm w/ nit https://codereview.chromium.org/13820024/diff/1/build/android/pylib/utils/reraiser_thread.py File build/android/pylib/utils/reraiser_thread.py (right): https://codereview.chromium.org/13820024/diff/1/build/android/pylib/utils/reraiser_thread.py#newcode115 build/android/pylib/utils/reraiser_thread.py:115: alive_thread_ids = {t.name: t.ident for t ...

7 years, 8 months ago (2013-04-09 19:03:10 UTC) #2

craigdh

7 years, 8 months ago (2013-04-10 00:43:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r193274 (presubmit successful).

Expand Messages | Collapse Messages