Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/script-tests/canvas-lineDash.js

Issue 1381973002: Disable canvas line dashing when dash sequence is all zeros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/canvas-lineDash-expected.txt ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp » ('j') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 description("Basic test for setLineDash, getLineDash and lineDashOffset"); 1 description("Basic test for setLineDash, getLineDash and lineDashOffset");
2 2
3 var canvas = document.createElement('canvas'); 3 var canvas = document.createElement('canvas');
4 document.body.appendChild(canvas); 4 document.body.appendChild(canvas);
5 canvas.setAttribute('width', '700'); 5 canvas.setAttribute('width', '700');
6 canvas.setAttribute('height', '700'); 6 canvas.setAttribute('height', '700');
7 var ctx = canvas.getContext('2d'); 7 var ctx = canvas.getContext('2d');
8 8
9 function dataToArray(data) { 9 function dataToArray(data) {
10 var result = new Array(data.length) 10 var result = new Array(data.length)
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 ctx.strokeRect(90.5, 10.5, 30, 30); 97 ctx.strokeRect(90.5, 10.5, 30, 30);
98 pixelShouldBe(95, 10, [0, 0, 0, 0]); 98 pixelShouldBe(95, 10, [0, 0, 0, 0]);
99 pixelShouldBe(105, 10, [0, 255, 0, 255]); 99 pixelShouldBe(105, 10, [0, 255, 0, 255]);
100 pixelShouldBe(120, 15, [0, 0, 0, 0]); 100 pixelShouldBe(120, 15, [0, 0, 0, 0]);
101 pixelShouldBe(120, 25, [0, 255, 0, 255]); 101 pixelShouldBe(120, 25, [0, 255, 0, 255]);
102 pixelShouldBe(115, 40, [0, 0, 0, 0]); 102 pixelShouldBe(115, 40, [0, 0, 0, 0]);
103 pixelShouldBe(105, 40, [0, 255, 0, 255]); 103 pixelShouldBe(105, 40, [0, 255, 0, 255]);
104 pixelShouldBe(90, 35, [0, 0, 0, 0]); 104 pixelShouldBe(90, 35, [0, 0, 0, 0]);
105 pixelShouldBe(90, 25, [0, 255, 0, 255]); 105 pixelShouldBe(90, 25, [0, 255, 0, 255]);
106 106
107 // Verify that all zero dash sequence results in no dashing
108 ctx.setLineDash([0, 0]);
Stephen White 2015/10/01 15:46:02 Please add a [null, null] case as well, since it's
Justin Novosad 2015/10/01 16:06:42 Done.
109 ctx.lineDashOffset = 0;
110 ctx.strokeRect(130.5, 10.5, 30, 30);
111 pixelShouldBe(130, 10, [0, 255, 0, 255]);
112 pixelShouldBe(130, 15, [0, 255, 0, 255]);
113 pixelShouldBe(130, 25, [0, 255, 0, 255]);
114 pixelShouldBe(130, 35, [0, 255, 0, 255]);
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/canvas/canvas-lineDash-expected.txt ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp » ('j') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698