Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1381943002: Compare overflowY value with OSCROLL for verticalScrollbar. (Closed)

Created:
5 years, 2 months ago by MuVen
Modified:
5 years, 2 months ago
Reviewers:
skobes, szager1
CC:
blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org, pdr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Compare overflowY value with OSCROLL for verticalScrollbar. Compare overflowY value with OSCROLL for verticalScrollbar. Small typo from https://codereview.chromium.org/1373413002/ CL. BUG=522389 #11 Committed: https://crrev.com/00954cfbe91b2ec0ef4b6b4cbba990fb7ffe396e Cr-Commit-Position: refs/heads/master@{#351853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/paint/DeprecatedPaintLayerScrollableArea.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
MuVen
PTAL
5 years, 2 months ago (2015-10-01 13:42:00 UTC) #2
szager1
lgtm, thanks for the catch.
5 years, 2 months ago (2015-10-01 15:22:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381943002/1
5 years, 2 months ago (2015-10-01 15:22:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/105678)
5 years, 2 months ago (2015-10-01 15:33:44 UTC) #7
MuVen
On 2015/10/01 15:33:44, commit-bot: I haz the power wrote: > Try jobs failed on following ...
5 years, 2 months ago (2015-10-01 16:37:02 UTC) #8
skobes
lgtm
5 years, 2 months ago (2015-10-01 17:05:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381943002/1
5 years, 2 months ago (2015-10-01 17:23:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-01 18:52:07 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 18:54:03 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00954cfbe91b2ec0ef4b6b4cbba990fb7ffe396e
Cr-Commit-Position: refs/heads/master@{#351853}

Powered by Google App Engine
This is Rietveld 408576698