Fix the benchmark app to handle real-world events

apps/benchmark/event.cc

Index: apps/benchmark/event.cc
diff --git a/apps/benchmark/event.cc b/apps/benchmark/event.cc
index 146d8dfb5b05c68c35896ec51d824c0ceb40db13..659c3025aa0e93a50e5bbd13d2766e9ce6eb5f2c 100644
--- a/apps/benchmark/event.cc
+++ b/apps/benchmark/event.cc
@@ -10,6 +10,7 @@
 #include "base/json/json_reader.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/values.h"
 
 namespace benchmark {
@@ -32,7 +33,7 @@ Event::~Event() {}
 namespace {
 // ID uniquely identifying an asynchronous event stack.
 struct AsyncEventStackId {
-  int id;
+  std::string id;
   std::string cat;
 };
 
@@ -41,28 +42,49 @@ bool operator<(const AsyncEventStackId& t, const AsyncEventStackId& o) {
 }
 
 // ID uniquely identifying a duration event stack.
-typedef int DurationEventStackId;
+typedef std::string DurationEventStackId;
+
+bool ExtractKeyAsString(base::DictionaryValue* event_dict,
+                        const std::string& key,
+                        std::string* output) {
+  const base::Value* value;
+  if (!event_dict->Get(key, &value)) {
+    LOG(ERROR) << "Incorrect trace event (missing " + key + "): "
+               << *event_dict;
+    return false;
+  }
 
-// Makes a unique id for a duration event stack.
-bool GetDurationEventStackId(base::DictionaryValue* event_dict,
-                             DurationEventStackId* durationId) {
-  if (!event_dict->GetInteger("tid", durationId)) {
-    LOG(ERROR) << "Incorrect trace event (missing tid).";
+  if (value->IsType(base::Value::TYPE_INTEGER)) {
+    int id_int;
+    // We already verified the type, so it should be an integer.
+    DCHECK(value->GetAsInteger(&id_int));
+    *output = base::IntToString(id_int);
+  } else if (value->IsType(base::Value::TYPE_STRING)) {
+    DCHECK(value->GetAsString(output));
+  } else {
+    LOG(ERROR) << "Incorrect trace event (" + key +
+                      " not a string or integer): "
+               << *event_dict;
     return false;
   }
   return true;
 }
 
+// Makes a unique id for a duration event stack.
+bool GetDurationEventStackId(base::DictionaryValue* event_dict,
+                             DurationEventStackId* durationId) {
+  return ExtractKeyAsString(event_dict, "tid", durationId);
+}
+
 // Makes a unique key for an async event stack.
 bool GetAsyncEventStackId(base::DictionaryValue* event_dict,
                           AsyncEventStackId* asyncId) {
-  if (!event_dict->GetInteger("id", &asyncId->id)) {
-    LOG(ERROR) << "Incorrect async trace event (missing id).";
+  if (!ExtractKeyAsString(event_dict, "id", &asyncId->id)) {
     return false;
   }
 
-  // We can have an empty category, but it is still relevant for event merging,
-  // per the documentation.
+  // We can have an empty category, but it is still relevant for event
+  // merging per the documentation.
   std::string cat;
   event_dict->GetString("cat", &asyncId->cat);
 
@@ -195,10 +217,7 @@ bool ParseEvents(base::ListValue* event_list, std::vector<Event>* result) {
       return false;
     }
 

[ppi, 2015/10/01 13:59:10]

please add a comment explaining that this will fail if there is no category, but
we decide to allow this because some clients record events without category.

[etiennej, 2015/10/01 14:03:36]

Done.

-    if (!event_dict->GetString("cat", &event.categories)) {
-      LOG(WARNING) << "Ignoring incorrect trace event (no categories)";
-      continue;
-    }
+    event_dict->GetString("cat", &event.categories);
 
     double timestamp;
     if (!event_dict->GetDouble("ts", &timestamp)) {