Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1381933002: Fix the benchmark app to handle real-world events (Closed)

Created:
5 years, 2 months ago by etiennej
Modified:
5 years, 2 months ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

- Allow event ids and tids to be either strings or integers - Allow events without a category R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/014f4f9b5301f8af1017f98f731aa183a4a3e11a

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : #

Total comments: 8

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -15 lines) Patch
M apps/benchmark/event.cc View 1 2 3 4 4 chunks +36 lines, -15 lines 0 comments Download
M apps/benchmark/event_unittest.cc View 1 2 3 2 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
etiennej
5 years, 2 months ago (2015-10-01 13:01:34 UTC) #2
ppi
lgtm % comments, thanks! https://codereview.chromium.org/1381933002/diff/1/apps/benchmark/event.cc File apps/benchmark/event.cc (right): https://codereview.chromium.org/1381933002/diff/1/apps/benchmark/event.cc#newcode74 apps/benchmark/event.cc:74: LOG(ERROR) << "Incorrect async trace ...
5 years, 2 months ago (2015-10-01 13:09:44 UTC) #3
ppi
PS also % trybots
5 years, 2 months ago (2015-10-01 13:10:09 UTC) #4
etiennej
PTAL, I added a few things (see updated description) https://codereview.chromium.org/1381933002/diff/1/apps/benchmark/event.cc File apps/benchmark/event.cc (right): https://codereview.chromium.org/1381933002/diff/1/apps/benchmark/event.cc#newcode74 apps/benchmark/event.cc:74: ...
5 years, 2 months ago (2015-10-01 13:25:17 UTC) #5
ppi
https://codereview.chromium.org/1381933002/diff/40001/apps/benchmark/event.cc File apps/benchmark/event.cc (left): https://codereview.chromium.org/1381933002/diff/40001/apps/benchmark/event.cc#oldcode198 apps/benchmark/event.cc:198: if (!event_dict->GetString("cat", &event.categories)) { Why this change? https://codereview.chromium.org/1381933002/diff/40001/apps/benchmark/event.cc File ...
5 years, 2 months ago (2015-10-01 13:31:16 UTC) #6
etiennej
https://codereview.chromium.org/1381933002/diff/40001/apps/benchmark/event.cc File apps/benchmark/event.cc (left): https://codereview.chromium.org/1381933002/diff/40001/apps/benchmark/event.cc#oldcode198 apps/benchmark/event.cc:198: if (!event_dict->GetString("cat", &event.categories)) { On 2015/10/01 13:31:16, ppi wrote: ...
5 years, 2 months ago (2015-10-01 13:41:47 UTC) #7
ppi
lgtm % comment, thanks! https://codereview.chromium.org/1381933002/diff/60001/apps/benchmark/event.cc File apps/benchmark/event.cc (right): https://codereview.chromium.org/1381933002/diff/60001/apps/benchmark/event.cc#newcode219 apps/benchmark/event.cc:219: please add a comment explaining ...
5 years, 2 months ago (2015-10-01 13:59:10 UTC) #8
etiennej
Committed patchset #5 (id:80001) manually as 014f4f9b5301f8af1017f98f731aa183a4a3e11a (presubmit successful).
5 years, 2 months ago (2015-10-01 14:02:15 UTC) #9
etiennej
5 years, 2 months ago (2015-10-01 14:03:36 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/1381933002/diff/60001/apps/benchmark/event.cc
File apps/benchmark/event.cc (right):

https://codereview.chromium.org/1381933002/diff/60001/apps/benchmark/event.cc...
apps/benchmark/event.cc:219: 
On 2015/10/01 13:59:10, ppi wrote:
> please add a comment explaining that this will fail if there is no category,
but
> we decide to allow this because some clients record events without category.

Done.

Powered by Google App Engine
This is Rietveld 408576698