Change HTMLAreaElement.idl to reflect changes in IDL as per spec

Change HTMLAreaElement.idl to reflect changes in IDL as per spec

https://html.spec.whatwg.org/multipage/embedded-content.html#htmlareaelement

Committed: https://crrev.com/d1eee5bdec4e21fc7e0b376e00f4492a940bdbdb
Cr-Commit-Position: refs/heads/master@{#356272}

[tanay.c, 2015-10-06 06:19:10]

tanay.c@samsung.com changed reviewers:
+ pdr@chromium.org, philipj@opera.com

[tanay.c, 2015-10-06 06:19:11]

PTAL

[philipj_slow, 2015-10-06 08:56:25]

It looks like the hreflang attribute doesn't actually have any effect, even on
HTMLAnchorElement, and the other engines don't have HTMLAreaElement.hreflang.

I've filed a spec bug to remove the attribute instead:
https://github.com/whatwg/html/issues/232

[philipj_slow, 2015-10-07 15:01:07]

On 2015/10/06 08:56:25, philipj wrote:
> It looks like the hreflang attribute doesn't actually have any effect, even on
> HTMLAnchorElement, and the other engines don't have HTMLAreaElement.hreflang.
> 
> I've filed a spec bug to remove the attribute instead:
> https://github.com/whatwg/html/issues/232

I got it removed from the spec instead. If you want to update the comment in the
IDL file to match the spec, that would be nice.

[tanay.c, 2015-10-08 06:34:30]

On 2015/10/07 15:01:07, philipj wrote:
> On 2015/10/06 08:56:25, philipj wrote:
> > It looks like the hreflang attribute doesn't actually have any effect, even
on
> > HTMLAnchorElement, and the other engines don't have
HTMLAreaElement.hreflang.
> > 
> > I've filed a spec bug to remove the attribute instead:
> > https://github.com/whatwg/html/issues/232
> 
> I got it removed from the spec instead. If you want to update the comment in
the
> IDL file to match the spec, that would be nice.

Done. PTAL.

[philipj_slow, 2015-10-08 09:07:47]

https://codereview.chromium.org/1381913002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLAreaElement.idl (right):

https://codereview.chromium.org/1381913002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLAreaElement.idl:30: // FIXME: download,
rel, relList and type are missing.
Please also remove type here and copy the comment from the spec: "// hreflang
and type are not reflected"

[tanay.c, 2015-10-08 10:59:55]

On 2015/10/08 09:07:47, philipj wrote:
>
https://codereview.chromium.org/1381913002/diff/80001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/html/HTMLAreaElement.idl (right):
> 
>
https://codereview.chromium.org/1381913002/diff/80001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/html/HTMLAreaElement.idl:30: // FIXME:
download,
> rel, relList and type are missing.
> Please also remove type here and copy the comment from the spec: "// hreflang
> and type are not reflected"

PTAL

[philipj_slow, 2015-10-08 11:13:16]

LGTM, and I've tweaked the description slightly.

Note that the spec issue was reopened, so let's wait for 24 hours before landing
this, just in case it's reverted.

[tanay.c, 2015-10-13 15:29:35]

On 2015/10/08 11:13:16, philipj wrote:
> LGTM, and I've tweaked the description slightly.
> 
> Note that the spec issue was reopened, so let's wait for 24 hours before
landing
> this, just in case it's reverted.

Can this be landed?

[philipj_slow, 2015-10-16 14:09:51]

On 2015/10/13 15:29:35, tanay.c wrote:
> On 2015/10/08 11:13:16, philipj wrote:
> > LGTM, and I've tweaked the description slightly.
> > 
> > Note that the spec issue was reopened, so let's wait for 24 hours before
> landing
> > this, just in case it's reverted.
> 
> Can this be landed?

Please wait a little, the proposal I've made would actually change this again:
https://github.com/whatwg/html/issues/232#issuecomment-148727450

[philipj_slow, 2015-10-20 13:05:56]

On 2015/10/16 14:09:51, philipj wrote:
> On 2015/10/13 15:29:35, tanay.c wrote:
> > On 2015/10/08 11:13:16, philipj wrote:
> > > LGTM, and I've tweaked the description slightly.
> > > 
> > > Note that the spec issue was reopened, so let's wait for 24 hours before
> > landing
> > > this, just in case it's reverted.
> > 
> > Can this be landed?
> 
> Please wait a little, the proposal I've made would actually change this again:
> https://github.com/whatwg/html/issues/232#issuecomment-148727450

OK, it's done, hreflang and type aren't mentioned in the IDL blocks at all any
longer.

[tanay.c, 2015-10-21 06:38:06]

On 2015/10/20 13:05:56, philipj wrote:
> On 2015/10/16 14:09:51, philipj wrote:
> > On 2015/10/13 15:29:35, tanay.c wrote:
> > > On 2015/10/08 11:13:16, philipj wrote:
> > > > LGTM, and I've tweaked the description slightly.
> > > > 
> > > > Note that the spec issue was reopened, so let's wait for 24 hours before
> > > landing
> > > > this, just in case it's reverted.
> > > 
> > > Can this be landed?
> > 
> > Please wait a little, the proposal I've made would actually change this
again:
> > https://github.com/whatwg/html/issues/232#issuecomment-148727450
> 
> OK, it's done, hreflang and type aren't mentioned in the IDL blocks at all any
> longer.

Is it ok to land in current state. Or should I remove the comment from the idl 
completely?

[philipj_slow, 2015-10-21 07:09:28]

On 2015/10/21 06:38:06, tanay.c wrote:
> On 2015/10/20 13:05:56, philipj wrote:
> > On 2015/10/16 14:09:51, philipj wrote:
> > > On 2015/10/13 15:29:35, tanay.c wrote:
> > > > On 2015/10/08 11:13:16, philipj wrote:
> > > > > LGTM, and I've tweaked the description slightly.
> > > > > 
> > > > > Note that the spec issue was reopened, so let's wait for 24 hours
before
> > > > landing
> > > > > this, just in case it's reverted.
> > > > 
> > > > Can this be landed?
> > > 
> > > Please wait a little, the proposal I've made would actually change this
> again:
> > > https://github.com/whatwg/html/issues/232#issuecomment-148727450
> > 
> > OK, it's done, hreflang and type aren't mentioned in the IDL blocks at all
any
> > longer.
> 
> Is it ok to land in current state. Or should I remove the comment from the idl

> completely?

Remove the "hreflang and type are not reflected" comment.

[tanay.c, 2015-10-21 09:05:14]

On 2015/10/21 07:09:28, philipj wrote:
> On 2015/10/21 06:38:06, tanay.c wrote:
> > On 2015/10/20 13:05:56, philipj wrote:
> > > On 2015/10/16 14:09:51, philipj wrote:
> > > > On 2015/10/13 15:29:35, tanay.c wrote:
> > > > > On 2015/10/08 11:13:16, philipj wrote:
> > > > > > LGTM, and I've tweaked the description slightly.
> > > > > > 
> > > > > > Note that the spec issue was reopened, so let's wait for 24 hours
> before
> > > > > landing
> > > > > > this, just in case it's reverted.
> > > > > 
> > > > > Can this be landed?
> > > > 
> > > > Please wait a little, the proposal I've made would actually change this
> > again:
> > > > https://github.com/whatwg/html/issues/232#issuecomment-148727450
> > > 
> > > OK, it's done, hreflang and type aren't mentioned in the IDL blocks at all
> any
> > > longer.
> > 
> > Is it ok to land in current state. Or should I remove the comment from the
idl
> 
> > completely?
> 
> Remove the "hreflang and type are not reflected" comment.

PTAL

[philipj_slow, 2015-10-21 09:08:33]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-10-21 09:08:33]

lgtm

[commit-bot: I haz the power, 2015-10-21 09:08:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1381913002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1381913002/120001

[commit-bot: I haz the power, 2015-10-21 09:08:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 09:08:51]

The author tanay.c@samsung.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[tanay.c, 2015-10-25 12:32:03]

The CQ bit was checked by tanay.c@samsung.com

[commit-bot: I haz the power, 2015-10-25 12:32:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1381913002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1381913002/120001

[commit-bot: I haz the power, 2015-10-25 12:32:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-25 12:32:20]

The author tanay.c@samsung.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[tanay.c, 2015-10-26 10:38:15]

On 2015/10/25 12:32:20, commit-bot: I haz the power wrote:
> The author mailto:tanay.c@samsung.com has not signed Google Contributor
License
> Agreement. Please visit https://cla.developers.google.com to sign and manage
> CLA.

I recently had an issue with my account and the CLA needs to be renewed. 
This patch will be landed as soon as this is done.

[tanay.c, 2015-10-27 10:56:54]

The CQ bit was checked by tanay.c@samsung.com

[commit-bot: I haz the power, 2015-10-27 10:57:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1381913002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1381913002/120001

[commit-bot: I haz the power, 2015-10-27 12:02:10]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-10-27 12:03:25]

Patchset 7 (id:??) landed as
https://crrev.com/d1eee5bdec4e21fc7e0b376e00f4492a940bdbdb
Cr-Commit-Position: refs/heads/master@{#356272}