Issue 1381863004: Fix mojo_ tools on the first run after adb kill-server.

Issue 1381863004: Fix mojo_ tools on the first run after adb kill-server. (Closed)

Created:
5 years, 2 months ago by ppi

Modified:
5 years, 2 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix mojo_ tools on the first run after adb kill-server. Fixes domokit/devtools#47. R=qsr@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/c3e3eac077c5cbb6250e50d3630f8c45b1fce693

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Address Ben's comments. #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -11 lines)			Patch
	M	mojo/devtools/common/devtoolslib/android_shell.py	View	1 2	3 chunks	+31 lines, -11 lines	0 comments	Download
	A	mojo/devtools/common/devtoolslib/android_shell_unittest.py	View		1 chunk	+61 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

qsr

LGTM with nits. https://codereview.chromium.org/1381863004/diff/20001/mojo/devtools/common/devtoolslib/android_shell.py File mojo/devtools/common/devtoolslib/android_shell.py (right): https://codereview.chromium.org/1381863004/diff/20001/mojo/devtools/common/devtoolslib/android_shell.py#newcode84 mojo/devtools/common/devtoolslib/android_shell.py:84: if len(spec.split()) == 2} What about ...

5 years, 2 months ago (2015-10-05 14:56:04 UTC) #2

ppi

https://codereview.chromium.org/1381863004/diff/20001/mojo/devtools/common/devtoolslib/android_shell.py File mojo/devtools/common/devtoolslib/android_shell.py (right): https://codereview.chromium.org/1381863004/diff/20001/mojo/devtools/common/devtoolslib/android_shell.py#newcode84 mojo/devtools/common/devtoolslib/android_shell.py:84: if len(spec.split()) == 2} On 2015/10/05 14:56:04, qsr wrote: ...

5 years, 2 months ago (2015-10-05 15:17:42 UTC) #3

ppi

5 years, 2 months ago (2015-10-05 15:18:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
c3e3eac077c5cbb6250e50d3630f8c45b1fce693 (presubmit successful).

Expand Messages | Collapse Messages