Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 138183003: Revert of Make ancestors of modal <dialog> inert (Closed)

Created:
6 years, 11 months ago by tdanderson
Modified:
6 years, 11 months ago
Reviewers:
falken, esprehn
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive, dominicc (has gone to gerrit), dmazzoni
Visibility:
Public.

Description

Revert of Make ancestors of modal <dialog> inert (https://codereview.chromium.org/133393002/) Reason for revert: This patch is the most probable cause of the failing content_browsertests: AccessibilityModalDialogInIframeOpened AccessibilityModalDialogOpened AccessibilityModalDialogStack See: http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/529 http://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/13227 http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/22361 http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/5388 I could not reach the patch author on IRC due to the time zone difference. Original issue's description: > Make ancestors of modal <dialog> inert > > As per spec change: http://html5.org/r/8343 > > Now, document.body is also inert. Previously events that > "skipped" an inert node were fired on document.body; now, > they are fired on document. > > Test: modal-dialog-ancestor-is-inert.html > Also, other tests cover some of this behavior and have > expectations updated. > > BUG=329407 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165040 TBR=esprehn@chromium.org,falken@chromium.org NOTREECHECKS=true NOTRY=true BUG=329407 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165086

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
tdanderson
Created Revert of Make ancestors of modal <dialog> inert
6 years, 11 months ago (2014-01-14 18:24:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/138183003/1
6 years, 11 months ago (2014-01-14 18:27:13 UTC) #2
commit-bot: I haz the power
Change committed as 165086
6 years, 11 months ago (2014-01-14 18:31:49 UTC) #3
esprehn
6 years, 11 months ago (2014-01-14 18:32:19 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698