Do not need to set suppress_next_commit_ to false in HandleCommit() method,

We don't need to set suppress_next_commit_ to false in HandleCommit() method, 
because this method can be called twice when using iBus. In this case, 
a compositing Korean Hangul character can be committed twice.  
 
Contributed by joone.hur@intel.com
 
BUG=50485
TEST=Follow the bug description.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195916

[joone, 2013-04-13 08:37:47]

Hello Ben,

50485 bug is reproducible with iBus 1.4.1 on my Ubuntu 12.04, but there is no
problem with scim.

Please take a look at my patch.

Thanks,
Joone

[Ben Goodger (Google), 2013-04-16 16:28:42]

-> erg for further triage.

[Elliot Glaysher, 2013-04-16 18:15:37]

Adding suzhe and penghuang from the bug.

[Elliot Glaysher, 2013-04-22 21:06:40]

suzhe and penghuang: one week ping. If you absolutely don't have time, I can
review this, but I'm not an expert here and want the opinion of someone who
really knows this code.

[James Su, 2013-04-23 01:50:24]

On 2013/04/22 21:06:40, Elliot Glaysher wrote:
> suzhe and penghuang: one week ping. If you absolutely don't have time, I can
> review this, but I'm not an expert here and want the opinion of someone who
> really knows this code.

Sorry for late. I missed it last week.

As I said in https://code.google.com/p/chromium/issues/detail?id=50485#c9
It's a problem of ibus. suppress_next_commit_ was introduced to work around the
problem, but it may have side effects in some corner cases.
For example when the user inputs something with a keyboard and triggers the code
path of setting suppress_next_commit_ to true by clicking somewhere, then inputs
more text with a handwriting pad, or a character picker, then the first commit
will be discard because suppress_next_commit_ was set to true and it'll only be
set to false on the next keyboard event or after discarding one commit event.
With this CL, the problem of such corner cases will be even worse, that all
following text input from a non-keyboard media will be discarded, until the user
uses keyboard again.

So the ultimate solution is to fix ibus and remove the code related to
suppress_next_commit_ completely.

But anyway, I'm ok to commit this CL as a work around for now, because such
corner case might be rare.

LGTM.

[commit-bot: I haz the power, 2013-04-23 02:41:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joone.hur@intel.com/13818036/1

[commit-bot: I haz the power, 2013-04-23 02:41:20]

Failed to apply patch for AUTHORS:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 233.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
===================================================================
--- AUTHORS	(revision 193683)
+++ AUTHORS	(working copy)
@@ -233,3 +233,4 @@
 Jun Jiang <jun.a.jiang@intel.com>
 Bobby Powers <bobbypowers@gmail.com>
 Patrick Riordan <patrickriordan177@gmail.com>
+Joone Hur <joone.hur@intel.com>

[Elliot Glaysher, 2013-04-23 16:50:41]

Could you please upload a new copy of this patch with a merged AUTHORS file?

[commit-bot: I haz the power, 2013-04-23 17:08:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joone.hur@intel.com/13818036/10002

[commit-bot: I haz the power, 2013-04-23 17:08:10]

Presubmit check for 13818036-10002 failed and returned exit status 1.

INFO:root:Found 2 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    content/browser/renderer_host/gtk_im_context_wrapper.cc

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[joone, 2013-04-23 17:08:32]

On 2013/04/23 16:50:41, Elliot Glaysher wrote:
> Could you please upload a new copy of this patch with a merged AUTHORS file?

I've updated the patch.
Thanks!

[commit-bot: I haz the power, 2013-04-23 17:16:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joone.hur@intel.com/13818036/10002

[commit-bot: I haz the power, 2013-04-23 17:16:31]

Presubmit check for 13818036-10002 failed and returned exit status 1.

INFO:root:Found 2 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    content/browser/renderer_host/gtk_im_context_wrapper.cc

Presubmit checks took 1.0s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[joone, 2013-04-23 17:37:21]

I got a LGTM from James Su, but my patch can not be committed because of missing
LGTM from a owner as follows:

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    content/browser/renderer_host/gtk_im_context_wrapper.cc


Could you add a LGTM to my patch?

[Avi (use Gerrit), 2013-04-23 17:40:01]

lgtm

stamp

[commit-bot: I haz the power, 2013-04-23 17:40:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joone.hur@intel.com/13818036/10002

[jam, 2013-04-23 20:28:35]

On 2013/04/23 17:37:21, joone wrote:
> I got a LGTM from James Su, but my patch can not be committed because of
missing
> LGTM from a owner as follows:
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
>     content/browser/renderer_host/gtk_im_context_wrapper.cc
> 
> 
> Could you add a LGTM to my patch?

next time only add one reviewer.

[commit-bot: I haz the power, 2013-04-23 22:20:00]

Change committed as 195916

[joone, 2013-04-23 22:38:35]

My first patch has finally landed. o/
@James @Elliot @Ben @Avi Thanks for helping review and commit my patch
@jam I see, I will add one reviewer next time.