Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1579)

Issue 1381803002: PPC: Full code shouldn't embed the type feedback vector. (Closed)

Created:
5 years, 2 months ago by MTBrandyberry
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Full code shouldn't embed the type feedback vector. Port c90c60ba2689fb524a1526503c9c87f534cf58fb Original commit message: Make sure to always reference it indirectly. This allows us to make the vector native-context dependent should we wish. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/6fb3708d68aa0a5c98bf026b099e068256800f64 Cr-Commit-Position: refs/heads/master@{#31036}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 3 chunks +5 lines, -14 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years, 2 months ago (2015-09-30 20:28:08 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381803002/1
5 years, 2 months ago (2015-09-30 20:28:27 UTC) #3
michael_dawson
On 2015/09/30 20:28:27, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years, 2 months ago (2015-09-30 20:56:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-30 21:11:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381803002/1
5 years, 2 months ago (2015-09-30 21:12:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 21:14:07 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 21:17:04 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6fb3708d68aa0a5c98bf026b099e068256800f64
Cr-Commit-Position: refs/heads/master@{#31036}

Powered by Google App Engine
This is Rietveld 408576698