Issue 13818013: Merged r13798, r13802, r13803, r13804, r13805, r14100 into 3.17 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13818013: Merged r13798, r13802, r13803, r13804, r13805, r14100 into 3.17 branch. (Closed)

Created:
7 years, 8 months ago by palfia

Modified:
7 years, 8 months ago

Reviewers:
kisg, Paul Lind, kilvadyb, danno, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.17

Visibility:
Public.

More Reviews

Description

Merged r13798, r13802, r13803, r13804, r13805, r14100 into 3.17 branch. MIPS: Refactor RegExpStub to check lazily. MIPS: Compile FastCloneShallowObjectStub using Crankshaft. MIPS: Fix materialization of arguments objects with unknown values. MIPS: Currently this mostly just moves code around. MIPS: Minor cleanup of CompareIC state MIPS: Make the mips port build cleanly with clang. R=danno@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14192

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+433 lines, -498 lines)			Patch
M	src/mips/code-stubs-mips.cc	View	20 chunks	+134 lines, -171 lines	0 comments	Download
M	src/mips/deoptimizer-mips.cc	View	6 chunks	+80 lines, -37 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	10 chunks	+61 lines, -35 lines	0 comments	Download
M	src/mips/lithium-mips.h	View	3 chunks	+14 lines, -1 line	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	src/mips/simulator-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/stub-cache-mips.cc	View	7 chunks	+129 lines, -245 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM. Some of the CL descriptions sound like stuff I wouldn't merge back, but since ...

7 years, 8 months ago (2013-04-09 17:02:54 UTC) #3

Message was sent while issue was closed.

Committed manually as r14192 (presubmit successful).

Expand Messages | Collapse Messages