Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 13818008: [content shell] only send the hyphenation file after the process was created (Closed)

Created:
7 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 8 months ago
Reviewers:
marja
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

[content shell] only send the hyphenation file after the process was created On windows, we cannot create an file handle for IPC before the process was created. BUG=111316 TEST=content_shell.exe --dump-render-tree doesn't crash in a debug build R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193343

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -7 lines) Patch
M content/shell/shell_content_browser_client.h View 4 chunks +11 lines, -1 line 0 comments Download
M content/shell/shell_content_browser_client.cc View 3 chunks +27 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
7 years, 8 months ago (2013-04-09 14:06:38 UTC) #1
marja
lgtm
7 years, 8 months ago (2013-04-09 14:13:50 UTC) #2
jochen (gone - plz use gerrit)
7 years, 8 months ago (2013-04-10 07:52:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r193343 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698