Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 1381753003: [GN]: Fix typo in roll_deps.py (Closed)

Created:
5 years, 2 months ago by Bons
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN]: Fix typo and a bug in the GN roll script. When complete, the script attempts to switch from the branches it creates to build and roll things back to the branch you were on before. The way it determines what branch you were on before is by looking at git's reflog. However, the way I was looking at the reflog was wrong; first, it was doing an re.match() instead of an re.search(), and so it was looking for a match at the beginning of the output (which would never be true). Second, we were looking at only the most recent entry, and when the roll script actually executed, the most recent entry would always be a commit, not a checkout, and so we wouldn't see what the previous branch was. BUG=none R=dpranke@chromium.org Committed: https://crrev.com/c9ef0df1e21a0e9be8c855fbbf01386ed0617d2a Cr-Commit-Position: refs/heads/master@{#351613}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : merge in dirk's patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M tools/gn/bin/roll_gn.py View 1 2 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Bons
5 years, 2 months ago (2015-09-30 17:50:38 UTC) #1
Dirk Pranke
lgtm. yay testing! :).
5 years, 2 months ago (2015-09-30 18:17:43 UTC) #2
Dirk Pranke
On 2015/09/30 18:17:43, Dirk Pranke wrote: > lgtm. > > yay testing! :). Oh, can ...
5 years, 2 months ago (2015-09-30 18:18:54 UTC) #3
Bons
On 2015/09/30 18:18:54, Dirk Pranke wrote: > On 2015/09/30 18:17:43, Dirk Pranke wrote: > > ...
5 years, 2 months ago (2015-09-30 18:20:55 UTC) #5
Bons
On 2015/09/30 18:20:55, Bons wrote: > On 2015/09/30 18:18:54, Dirk Pranke wrote: > > On ...
5 years, 2 months ago (2015-09-30 18:26:52 UTC) #7
Dirk Pranke
lgtm, thanks.
5 years, 2 months ago (2015-09-30 18:28:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381753003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381753003/40001
5 years, 2 months ago (2015-09-30 18:35:41 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-30 19:01:45 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 19:02:35 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c9ef0df1e21a0e9be8c855fbbf01386ed0617d2a
Cr-Commit-Position: refs/heads/master@{#351613}

Powered by Google App Engine
This is Rietveld 408576698