CQ to always post a message when Commit box is unchecked.

verification/fake.py

 # coding=utf8
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """A verifier that does nothing."""
 
 from verification import base
 
+def failed_message():
+  return 'FakeVerifier FAILED'
 
 class FakeVerifier(base.Verifier):
   name = 'fake'
 
   def __init__(self, state):
     super(FakeVerifier, self).__init__()
     self.state = state
 
   def verify(self, pending):
-    pending.verifications[self.name] = base.SimpleStatus(self.state)
+    fake = base.SimpleStatus(self.state)
+    # Make sure to leave a message, so CQ tests can reliably test for it

[Paweł Hajdan Jr., 2014/01/28 01:13:46]

nit: End all sentences with a dot, here and below.

+    if self.state == base.FAILED:
+      fake.error_message = failed_message()
+    pending.verifications[self.name] = fake
 
   def update_status(self, queue):
     pass
 
 
 class DeferredFakeVerifier(base.Verifier):
   name = 'fake'
 
   def __init__(self, state, delay):
     super(DeferredFakeVerifier, self).__init__()
     self.state = state
     self.delay = delay
 
   def verify(self, pending):
     pending.verifications[self.name] = base.SimpleStatus()
 
   def update_status(self, queue):
     if self.delay:
       self.delay -= 1
       return
 
     for _, fake in self.loop(queue, base.SimpleStatus, True):
       fake.state = self.state
+      # Make sure to leave a message, so CQ tests can reliably test for it
+      if self.state == base.FAILED:
+        fake.error_message = failed_message()