Issue 138173002: Ensure ElementData exists before modifying when animating class attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138173002: Ensure ElementData exists before modifying when animating class attribute (Closed)

Created:
6 years, 11 months ago by fs

Modified:
6 years, 11 months ago

Reviewers:
Stephen Chennney, esprehn, jochen (gone - plz use gerrit), eseidel

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), sof, eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, adamk+blink_chromium.org, darktears, Steve Block, dino_apple.com, Inactive, Eric Willigers, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Ensure ElementData exists before modifying when animating class attribute This is a merge of http://trac.webkit.org/changeset/153835 by Rob Buis <rwlbuis@webkit.org>;. BUG=334194 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165068

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -1 line)			Patch
A	LayoutTests/svg/animations/classAttributeSettingCrash.html	View	1 chunk	+12 lines, -0 lines	0 comments	Download
A +	LayoutTests/svg/animations/classAttributeSettingCrash-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/138173002/1

6 years, 11 months ago (2014-01-14 13:30:39 UTC) #3

esprehn

6 years, 11 months ago (2014-01-15 22:38:44 UTC) #5

Message was sent while issue was closed.

This patch is not right, you can't unconditionally allocate a
uniqueElementData() inside there, it defeats the ShareableElementData
optimization.

Expand Messages | Collapse Messages