Issue 1381703003: Pass --images '' to nanobench to disable image benchmarking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1381703003: Pass --images '' to nanobench to disable image benchmarking. (Closed)

Created:
5 years, 2 months ago by mtklein_C

Modified:
5 years, 2 months ago

Reviewers:
scroggo

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Pass --images '' to nanobench to disable image benchmarking. Enabling image benchmarking has caused most nanobench runs to fail, both Debug and Release. BUG=skia:3418 NOTREECHECKS=true TBR=scroggo@google.com Committed: https://skia.googlesource.com/skia/+/1f7039c6c5f0f118b629994b0bac255345e5abd6

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	tools/nanobench_flags.json	View		6 chunks	+6 lines, -0 lines	0 comments	Download
	M	tools/nanobench_flags.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1381703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1381703003/1

5 years, 2 months ago (2015-10-05 17:18:22 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/1f7039c6c5f0f118b629994b0bac255345e5abd6

5 years, 2 months ago (2015-10-05 17:25:02 UTC) #5

scroggo

5 years, 2 months ago (2015-10-08 20:04:32 UTC) #6

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1400633002/ by scroggo@google.com.

The reason for reverting is: I have attempted to fix the problems that caused
running nanobench with images to fail, so testing to see if they are in fact
fixed..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages