Issue 13817012: Add method to TouchSelectionController to check if a handle is currently being

Issue 13817012: Add method to TouchSelectionController to check if a handle is currently being (Closed)

Created:
7 years, 8 months ago by varunjain

Modified:
7 years, 8 months ago

Reviewers:
sadrul

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add method to TouchSelectionController to check if a handle is currently being dragged. Also fixes some handle positioning bugs. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195110

Patch Set 1 : patch #

Total comments: 2

Patch Set 2 : patch #

Patch Set 3 : merged with upstream #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -7 lines)			Patch
M	ui/base/touch/touch_editing_controller.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/views/touchui/touch_selection_controller_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/touchui/touch_selection_controller_impl.cc	View	1	3 chunks	+10 lines, -7 lines	0 comments	Download
M	ui/views/touchui/touch_selection_controller_impl_unittest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

sadrul

https://codereview.chromium.org/13817012/diff/2001/ui/views/touchui/touch_selection_controller_impl.cc File ui/views/touchui/touch_selection_controller_impl.cc (right): https://codereview.chromium.org/13817012/diff/2001/ui/views/touchui/touch_selection_controller_impl.cc#newcode41 ui/views/touchui/touch_selection_controller_impl.cc:41: views::Widget::InitParams params(views::Widget::InitParams::TYPE_TOOLTIP); Why do you need this change?

7 years, 8 months ago (2013-04-12 01:34:31 UTC) #2

varunjain

7 years, 8 months ago (2013-04-17 02:46:14 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/13817012/13001

7 years, 8 months ago (2013-04-18 18:26:30 UTC) #5

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30293

7 years, 8 months ago (2013-04-18 22:00:04 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/13817012/13001

7 years, 8 months ago (2013-04-19 03:44:02 UTC) #7

Message was sent while issue was closed.

Change committed as 195110

Expand Messages | Collapse Messages