third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp - Issue 1381693002: Don't report promise rejection events during the microtask checkpoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp

Issue 1381693002: Don't report promise rejection events during the microtask checkpoint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp

index 7f547c8717645c05590f3586053f0e2c63220617..2446664854b6550df260e7017949f1a0cbc43aaa 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.cpp

@@ -127,7 +127,7 @@ WorkerScriptController::~WorkerScriptController()

void WorkerScriptController::dispose()

{

m_rejectedPromises->dispose();

- m_rejectedPromises.clear();

+ m_rejectedPromises.release();

m_world->dispose();