third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp - Issue 1381693002: Don't report promise rejection events during the microtask checkpoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 1381693002: Don't report promise rejection events during the microtask checkpoint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updates Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h ('k') | third_party/WebKit/Source/bindings/core/v8/WorkerScriptController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

index e24e5d2510830cf8e31c15e5b582dc69c0530206..5511c68fe1e93f84d99ccac5b0513ec4caa04183 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

@@ -192,7 +192,7 @@ namespace {

static RejectedPromises& rejectedPromisesOnMainThread()

{

ASSERT(isMainThread());

- DEFINE_STATIC_LOCAL(OwnPtrWillBePersistent<RejectedPromises>, rejectedPromises, (adoptPtrWillBeNoop(new RejectedPromises())));

+ DEFINE_STATIC_LOCAL(RefPtrWillBePersistent<RejectedPromises>, rejectedPromises, (adoptRefWillBeNoop(new RejectedPromises())));

return *rejectedPromises;

}