url: Get rid of UTF16Char type.

url: Get rid of UTF16Char type.

Now that Blink was merged into Chromium, this patch can be done without
the three-patch dance for something really trivial.

This patch just changes Blink code to use base::char16 type directly
instead of using deprecated url type.

BUG=None
R=brettw@chromium.org,dglazkov@chromium.org

Committed: https://crrev.com/bf7eca2ada9d9431f5d7e3c74d5108791ad2b06c
Cr-Commit-Position: refs/heads/master@{#369078}

[tfarina, 2015-10-05 17:01:07]

PTAL

[brettw, 2015-10-05 18:08:23]

https://codereview.chromium.org/1381683003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/weborigin/KURL.cpp (right):

https://codereview.chromium.org/1381683003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/weborigin/KURL.cpp:104: void
ConvertFromUTF16(const base::char16* input, int inputLength, url::CanonOutput*
output) override
There's a blink thread discussing what from base we want to use. I think this is
fine because it's the underlying type for the URL code that Blink is already
using, but we should follow up there for explicit guidance.

[esprehn, 2015-10-05 18:24:28]

You're missing some sites:

../../third_party/WebKit/Source/platform/weborigin/KURL.cpp:668:31: error: no
member named 'UTF16Char' in namespace 'url'
    url::RawCanonOutputT<url::UTF16Char> unescaped;
                         ~~~~~^
../../third_party/WebKit/Source/platform/weborigin/KURL.cpp:668:42: error: C++
requires a type specifier for all declarations
    url::RawCanonOutputT<url::UTF16Char> unescaped;

[tfarina, 2015-10-05 18:36:19]

Fixed. PTAL Elliot.

[tfarina, 2016-01-06 15:32:18]

tfarina@chromium.org changed reviewers:
+ esprehn@chromium.org, tkent@chromium.org

[tfarina, 2016-01-06 15:32:18]

Elliot, Kent, is this possible now?

[brettw, 2016-01-08 18:09:49]

url lgtm, but be sure to get OK from esprehn also.

[dglazkov, 2016-01-12 16:29:32]

dglazkov@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dglazkov, 2016-01-12 16:29:32]

lgtm

[tfarina, 2016-01-12 22:31:55]

Description was changed from

==========
url: Get rid of UTF16Char type.

Now that Blink was merged into Chromium, this patch can be done without
the three-patch dance for something really trivial.

This patch just changes Blink code to use base::char16 type directly
instead of using deprecated url type.

BUG=None
R=brettw@chromium.org
==========

to

==========
url: Get rid of UTF16Char type.

Now that Blink was merged into Chromium, this patch can be done without
the three-patch dance for something really trivial.

This patch just changes Blink code to use base::char16 type directly
instead of using deprecated url type.

BUG=None
R=brettw@chromium.org,dglazkov@chromium.org
==========

[tfarina, 2016-01-12 22:32:01]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2016-01-12 22:32:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
dglazkov@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1381683003/#ps40001
(title: "REBASE")

[commit-bot: I haz the power, 2016-01-12 22:32:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1381683003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1381683003/40001

[commit-bot: I haz the power, 2016-01-13 02:23:00]

Description was changed from

==========
url: Get rid of UTF16Char type.

Now that Blink was merged into Chromium, this patch can be done without
the three-patch dance for something really trivial.

This patch just changes Blink code to use base::char16 type directly
instead of using deprecated url type.

BUG=None
R=brettw@chromium.org,dglazkov@chromium.org
==========

to

==========
url: Get rid of UTF16Char type.

Now that Blink was merged into Chromium, this patch can be done without
the three-patch dance for something really trivial.

This patch just changes Blink code to use base::char16 type directly
instead of using deprecated url type.

BUG=None
R=brettw@chromium.org,dglazkov@chromium.org
==========

[commit-bot: I haz the power, 2016-01-13 02:23:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-13 02:24:52]

Description was changed from

==========
url: Get rid of UTF16Char type.

Now that Blink was merged into Chromium, this patch can be done without
the three-patch dance for something really trivial.

This patch just changes Blink code to use base::char16 type directly
instead of using deprecated url type.

BUG=None
R=brettw@chromium.org,dglazkov@chromium.org
==========

to

==========
url: Get rid of UTF16Char type.

Now that Blink was merged into Chromium, this patch can be done without
the three-patch dance for something really trivial.

This patch just changes Blink code to use base::char16 type directly
instead of using deprecated url type.

BUG=None
R=brettw@chromium.org,dglazkov@chromium.org

Committed: https://crrev.com/bf7eca2ada9d9431f5d7e3c74d5108791ad2b06c
Cr-Commit-Position: refs/heads/master@{#369078}
==========

[commit-bot: I haz the power, 2016-01-13 02:24:53]

Patchset 3 (id:??) landed as
https://crrev.com/bf7eca2ada9d9431f5d7e3c74d5108791ad2b06c
Cr-Commit-Position: refs/heads/master@{#369078}